feat: Add transaction authorization boundary tests - #196
Merged
El-swaggerito merged 1 commit intoJul 22, 2026
Merged
Conversation
Add comprehensive test suite covering transaction authorization boundaries between account data, wallet secrets, and signing operations. Tests cover: - Transaction preparation without signing (3 tests) - Signing requirements and validation (5 tests) - Missing/invalid signer scenarios (5 tests) - Unsigned transaction submission prevention (4 tests) - Multi-signature authorization boundaries (2 tests) - Security boundary documentation (5 tests) Total: 24 new tests, all passing. No regressions in existing 455 tests. Closes Axionvera#161
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive transaction authorization boundary tests that verify the security boundaries between transaction preparation, signing, and submission operations.
Changes
Added
tests/transaction-authorization.test.tswith 24 new tests covering:Transaction Preparation (3 tests)
Signing Requirements (5 tests)
Missing or Invalid Signer Scenarios (5 tests)
Unsigned Transaction Submission Prevention (4 tests)
Multi-Signature Authorization Boundaries (2 tests)
Security Boundary Documentation (5 tests)
Test Results
Security Contract
These tests enforce the SDK's security contract:
This test suite documents and enforces these boundaries to prevent future refactors from accidentally allowing signing behavior in places that should only prepare or inspect transactions.
Closes #161