Skip to content

feat: add SDK diagnostics and observability hooks with strict redaction - #324

Merged
El-swaggerito merged 2 commits into
Axionvera:mainfrom
PatrickKish1:feat/276-sdk-diagnostics
Jul 27, 2026
Merged

feat: add SDK diagnostics and observability hooks with strict redaction#324
El-swaggerito merged 2 commits into
Axionvera:mainfrom
PatrickKish1:feat/276-sdk-diagnostics

Conversation

@PatrickKish1

Copy link
Copy Markdown
Contributor

Summary

  • Adds opt-in SDK diagnostics (src/diagnostics/) for configuration, network, transaction lifecycle, wallet capability, and vault readiness.
  • Lifecycle hooks are off by default (enableDiagnostics / setDiagnosticsHooks); emits are no-ops until enabled.
  • Strict redaction via deny-listed keys + string scrubbing so secret keys, mnemonics, signed XDR, and related material never reach hooks or reports.
  • Soft instrumentation in config, wallet, transactions, submit/retry, and vault readiness paths without changing existing public call signatures.
  • Documents safe support workflows in docs/diagnostics.md (linked from README, support policy, architecture, and logging docs).

Closes #276

Test plan

  • npm run test -- tests/diagnostics.test.ts tests/exports.test.ts (18 passed)
  • npm run lint (tsc --noEmit)
  • npm run check:circular
  • Spot-check: enable hooks → createWallet() event has publicKey / hasSecretKey and no raw secretKey
  • Spot-check: buildDiagnosticsReport({ network: 'testnet' }) JSON has no S… secrets

@El-swaggerito
El-swaggerito merged commit e044875 into Axionvera:main Jul 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SDK diagnostics and observability hooks with strict redaction

2 participants