Repository navigation
fix(acap-ssh-utils): Pass the password to sshpass through SSHPASS - #279
Merged
Merged
Conversation
apljungquist
approved these changes
Oct 29, 2026
guoxe
approved these changes
Nov 3, 2026
apljungquist
added a commit
to apljungquist/acap-cargo
that referenced
this pull request
Nov 8, 2026
Cherry picks acap-rs pull 279 [^1].
---
From acap-rs issue 270. `sshpass -p<pass>` exposed the password in the
process list, and `debug!("{cmd:#?}")` logged it. The password now goes
through `SSHPASS` with `sshpass -e`. `Command`'s `Debug` prints the
environment, so the debug logs show only the program and arguments.
Tested `make run` with `RUST_LOG=debug` against a P3248-LV on AXIS OS
11.11: the app is patched and runs, and the password does not appear in
the output.
[^1]: AxisCommunications/acap-rs#279
Co-authored-by: Alex Fishlock <alex.fishlock@racingjag.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #270.
sshpass -p<pass>exposed the password in the process list, anddebug!("{cmd:#?}")logged it. The password now goes throughSSHPASSwithsshpass -e.Command'sDebugprints the environment, so the debug logs show only the program and arguments.Tested
make runwithRUST_LOG=debugagainst a P3248-LV on AXIS OS 11.11: the app is patched and runs, and the password does not appear in the output.