Skip to content

fix(acap-vapix): systemready parsing and request body - #280

Open
fishloa wants to merge 5 commits into
AxisCommunications:mainfrom
fishloa:systemready-fixes
Open

fishloa wants to merge 5 commits into
AxisCommunications:mainfrom
fishloa:systemready-fixes

Conversation

@fishloa

@fishloa fishloa commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

From #270.

  • preview_mode() returned the uptime field.
  • Without a timeout the request sent the string "{}" instead of an empty object.
  • uptime and previewmode are parsed when deserializing, so bad device data is an error instead of a panic.

Checked against a P3268-LV (AXIS OS 12.11) and a P3248-LV (AXIS OS 11.11), with and without a timeout: main reports preview_mode() == uptime(); this returns None, since neither device sends previewmode.

The preview_mode test uses the existing 11_11_initial_response.json fixture. None of the 15 devices I checked (AXIS OS 11.11 and 12.11) send previewmode; all are past initial setup.

@fishloa
fishloa requested a review from a team as a code owner October 29, 2026 15:15
apljungquist
apljungquist previously approved these changes Oct 30, 2026

@apljungquist apljungquist left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants