Repository navigation
fix(axoverlay): Clear the render callback when Api is dropped - #281
Conversation
I think most checksums reproduce in the dev container on all hosts and that all checksums reproduce on certain hosts. May be worth a try next time to not have to wait for the CI run. |
Tried that earlier in the dev container on an Apple Silicon Mac (amd64 emulation); all 18 checksums differed from CI, so I took them from CI. Updated now. |
That's worse than I remember 🤔 Are you sure emulation is on? |
It was ( |
|
@fishloa is the squash and merge button enabled for you? |
|
Actually, I only have read access, not merge rights at all. I'm happy if you want to grant me rights to merge. |
I can't grant you any permissions in this repo. But I can merge PRs once they are approved by Axis. Would you like me to do that straight away or explicitly ask for them to be merged? |
|
I really don't mind. I am happy making PRs for issues that I find, and generally contributing. Whatever process you and Axis want to follow.. just let me know. |
|
I'll merge them proactively to reduce latency from communication round trips by default. But feel free to mention me when something need merging, I can easily miss that something is ready. |
From #270.
Drop for Apicleared the adjustment callback but not the render callback, so a secondApiwith a render callback panicked with "Render function already set".Tested on a P3268-LV (AXIS OS 12.11) with
axoverlay_examplechanged locally to create and drop anApiwith a render callback before the real one: main panics at startup, this runs and renders. That test change is not included.