Skip to content

Improve full view functionality in ReadmeCard#298

Merged
fridajac merged 3 commits into
mainfrom
icon
Aug 22, 2025
Merged

Improve full view functionality in ReadmeCard#298
fridajac merged 3 commits into
mainfrom
icon

Conversation

@fridajac
Copy link
Copy Markdown
Contributor

Hey, I just made a Pull Request!

Changes:

  • Replaced the full screen icon with the more appropriate MUI FullscreenIcon. This to better indicate that a new full view dialog has been opened.
  • Added functionality for maintaining the full view state in the URL, making it possible for user to link directly to the full view.

Context

In our Axis Backstage application, we use different full screen icons in different components. We should be consistent and always use the MUI FullscreenIcon.

In addition, only handling the full view of the ReadmeCard through an useState-hook won't make it possible for user to link directly to the full view. Handling it in the URL is a more commonly used approach.

Screenshots

Screenshot from 2025-07-24 10-53-51 Screenshot from 2025-07-24 10-53-47

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have verified that my code follows the style already available in the repository
  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@fridajac fridajac requested a review from a team as a code owner July 24, 2025 08:54
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 24, 2025

🦋 Changeset detected

Latest commit: 32b5121

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@axis-backstage/plugin-readme Minor
app Patch
backend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fridajac fridajac merged commit 2a2afb8 into main Aug 22, 2025
6 checks passed
@fridajac fridajac deleted the icon branch August 22, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants