OPC-UA Plugin Server: First commit #2

alexo-w · 2025-05-07T11:18:14Z

First version including:

ACAP Code
Documentation
Open source information

Change-Id: Ia86659a120fcb728dfb1c373495ca24162416242

Describe your changes

Please include a summary of the change, a relevant motivation and context.

Issue ticket number and link

Fixes #(issue)

Checklist before requesting a review

I have performed a self-review of my own code
I have verified that the code builds perfectly fine on my local system
I have added tests that prove my fix is effective or that my feature works
I have commented my code, particularly in hard-to-understand areas
I have verified that my code follows the style already available in the repository
I have made corresponding changes to the documentation

LICENSE

README.md

First version including: * ACAP Code * Documentation * Open source information Change-Id: Ia86659a120fcb728dfb1c373495ca24162416242

Check if the UID/GID already exist before attempting to add them to the Docker image. Reuse their associated names in case they already exist. Change-Id: Ie1f4aa22dd47e33f9cdfdd8865912c3eba02c349

Change-Id: I42c325178626b1775b766d7397d3d1bb899e0932

Change-Id: I3f5c729aef58cf3167ea5c4a33aba63c5e0316c2

Change-Id: I6b4f79f27098d8d5f4f17c2eeb75974b20def52e

Change-Id: I19bff150c3de803ffe12b15ca71066d3f9ed070a

Change-Id: I917e8504c72700f8ec3a3dc9058e27ba22dd8e2c

Change-Id: Ibc08dfccb2e725ff4c8992dad074fdb41b2d3063

Change-Id: I8e4ecdd14cd0f23a0953ef13bb464a0360d655ae

Change-Id: I68edcb41f8bb51a838e250153631911547656ef5

Change-Id: I8e7aff33d29d96aff6fb466b6b7a005ad6891cb7

devel-containers/Dockerfile.devimg

README.md

isak-jakobsson · 2025-06-23T08:25:59Z

Dockerfile

In the documentation there is this guide for how to install third party libraries: https://developer.axis.com/acap/develop/include-third-party-libraries/, where it is recommended to install into the opt/build directory and then move the files to opt/app/lib. Then in the Makefile you have to provide:

LDLIBS += -Llib/ CFLAGS += -Ilib/include SHLIB_DIR = ./lib LDFLAGS = -L$(SHLIB_DIR) -Wl,--no-as-needed,-rpath,'$$ORIGIN/lib' SHLIBS += -lm -l[lib](linking-third-party-lib)

I am not set on that the documentation shows the "best" way, so I'm interested to learn how you install third party libraries here, and why you don't need to specify a .e.g., rpath in your Makefile?

We kind of "inherited" the example(s) provided by Core Tech Systems (including their Dockerfile) and we just went with it. In this case we use static linking to link with libopen62541.a.

* Docker - remove dobule ARG ARCH=aarch64 * README - rename section header Change-Id: I9b247ce64f752f7414cfa902a5b6d6058798d145

GHakansson · 2025-06-27T07:43:23Z

app/Makefile

+CFLAGS += $(shell PKG_CONFIG_PATH=$(PKG_CONFIG_PATH) pkg-config --cflags $(PKGS))
+LDLIBS += $(shell PKG_CONFIG_PATH=$(PKG_CONFIG_PATH) pkg-config --libs $(PKGS))
+
+LIB_OPEN62541 = $(SDKTARGETSYSROOT)/usr/lib/libopen62541.a


Is this lib already installed in the firmware on the devices listed as supported below? I cannot find it on my device and no installation of it in these makefiles either.

The Open62541 lib is built and installed in the dockerfile, so when building the application.

Its line 94-104 in the dockerfile? Have you considered to bundle the lib with the ACAP instead? Here's an example of this: https://github.com/AxisCommunications/acap-native-sdk-examples-staging/tree/main/utility-libraries/custom_lib_example/app/custom_build

That way the library are automatically uninstalled with the ACAP

Yes, lines 94-104 are correct. As mentioned previously in the conversation above, we went with the example provided by Core Tech Systems and haven't considered changing it since it's working. If you think it's necessary, we could of course change it.

That way the library are automatically uninstalled with the ACAP

We build open62541 as a static library and link with it. It's only our ACAP that uses this library. Uninstalling the ACAP will not leave any library hanging behind on the Axis device.

If we ask this question, how is the lib supposed to be removed when the ACAP is uninstalled?

Ok, then I'm fine with it

Not sure it it's still unclear but the open62541 library is built inside the development container, it will never make it as a separate library onto the Axis device. We use static linking so it will be part of the binary executable - the ACAP application itself.

GHakansson · 2025-06-27T07:44:48Z

app/opcua_open62541.c

+  status = UA_Server_run(ctx->server, &ctx->ua_server_running);
+
+  LOG_D(&ctx->logger, "UA Server exit status: %s", UA_StatusCode_name(status));
+  UA_Server_delete(ctx->server);


Where is the implementation of this function?

I'm not sure which function you're referring to but both of these functions are from the open62541-lib.

Change-Id: I8ce2dfd95db4b79ef7d3c9252dc591b972c26b70

Change-Id: I42193fec0561992e265cd7d8530863f2242fb7db

Change-Id: Ia897b0b7e928a09705e4dd294c223e31fbfe7efe

Change-Id: I8b3fc584b3af41ddb1df19f383abdfb87a1c1504

mattias-kindborg-at-work reviewed Jun 17, 2025

View reviewed changes

alexo-w and others added 10 commits June 19, 2025 14:08

OPC-UA Plugin Server: First commit

b0efab5

First version including: * ACAP Code * Documentation * Open source information Change-Id: Ia86659a120fcb728dfb1c373495ca24162416242

Improve Docker image creation

652df95

Check if the UID/GID already exist before attempting to add them to the Docker image. Reuse their associated names in case they already exist. Change-Id: Ie1f4aa22dd47e33f9cdfdd8865912c3eba02c349

Documentation improvements

4fc1538

Change-Id: I42c325178626b1775b766d7397d3d1bb899e0932

License: Use MIT license

13b7f98

Change-Id: I3f5c729aef58cf3167ea5c4a33aba63c5e0316c2

chore: refactor super-linter settings

0511e36

chore: disable checkov in super-linter settings

c18e5ae

chore: disable some linters

dac7283

Change-Id: I6b4f79f27098d8d5f4f17c2eeb75974b20def52e

chore: add missing githook

e3edbdb

Change-Id: I19bff150c3de803ffe12b15ca71066d3f9ed070a

chore: use TABs in shell scripts under .githooks.d

dc9e394

Change-Id: I917e8504c72700f8ec3a3dc9058e27ba22dd8e2c

chore: fix spacing style

6307783

Change-Id: Ibc08dfccb2e725ff4c8992dad074fdb41b2d3063

alexo-w force-pushed the first_review branch from 58519e0 to 6307783 Compare June 19, 2025 12:21

alexo-w and others added 3 commits June 19, 2025 14:50

docs: Update name of license

31e6c59

Change-Id: I8e4ecdd14cd0f23a0953ef13bb464a0360d655ae

fix: Run mode - respawn and memleak

58af333

Change-Id: I68edcb41f8bb51a838e250153631911547656ef5

docs: fix wording

1b34f50

Change-Id: I8e7aff33d29d96aff6fb466b6b7a005ad6891cb7

isak-jakobsson reviewed Jun 23, 2025

View reviewed changes

fix: Docker, README

8281e0b

* Docker - remove dobule ARG ARCH=aarch64 * README - rename section header Change-Id: I9b247ce64f752f7414cfa902a5b6d6058798d145

GHakansson reviewed Jun 27, 2025

View reviewed changes

sola-ax and others added 4 commits June 27, 2025 14:06

chore: more files to ignore

fa88f4f

Change-Id: I8ce2dfd95db4b79ef7d3c9252dc591b972c26b70

docs: add build instructions for Windows machines

65cf7d8

Change-Id: I42193fec0561992e265cd7d8530863f2242fb7db

docs: memory usage info

a314daa

Change-Id: Ia897b0b7e928a09705e4dd294c223e31fbfe7efe

docs: memory usage updates

894450f

Change-Id: I8b3fc584b3af41ddb1df19f383abdfb87a1c1504

mattias-kindborg-at-work approved these changes Oct 24, 2025

View reviewed changes

sola-ax merged commit 627e3ab into main Oct 24, 2025
17 checks passed

sola-ax deleted the first_review branch October 24, 2025 10:16

OPC-UA Plugin Server: First commit #2

OPC-UA Plugin Server: First commit #2

Uh oh!

Conversation

alexo-w commented May 7, 2025

Describe your changes

Issue ticket number and link

Checklist before requesting a review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sola-ax Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sola-ax Jun 27, 2025 •

edited

Loading