Created flake for project #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Sorry this was too eager, need to get this check by the ngi review team |
Owner
|
Yes super simple to package, the only external thing is the third party check for the code loaded https://github.com/Ayms/bitcoin-transactions/blob/master/hash.txt (not so external right now because it is myself) |
1. src now equals lib.cleanSource ./. 2. supportedSystems expanded to any system that can run a browser 3. combined apps into single script with flags 4. created nixosModule which creates a .desktop file 5. removed unused version var 6. enclose bash vars in ""
Co-authored-by: Aaron Janse <[email protected]>
Author
|
Hi, This flake has been completed and integrates this project into the Nix ecosystem :0 It builds a package and exposes a shell command it also exposes a flag (clear || c) which runs the walletclear.html and makes it installable as a desktop item on NixOS through a nixosModule (which is why the png has been added to the repo as well) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty simple project to package as everything is already contained within the repository.
There are some apps that load the browser version and some addition checks that make use of the general tests in the project