-
Notifications
You must be signed in to change notification settings - Fork 581
chore: Bump Noir reference #15899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chore: Bump Noir reference #15899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Addressing remaining visibility errors in #16024. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 28, 2025
Needed to do the following to resolve remaining visibility issue that currently blocks [Noir sync](#15899): - Exposed a few modules from `Aztec.nr` as in the it's prohibited to access private modules. - Updated https://github.com/noir-lang/sha256 dependency as an older version had a visibility issue present.
This reverts commit af643a8.
benesjan
approved these changes
Jul 30, 2025
This was referenced Jul 30, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncs Noir up to commit
b28776c8a68dbc319e2ffcee350b8e2a71b20096and includes this commits:chore: Document type coercions (noir-lang/noir#9292)
feat: add better handling for follow-on optimizations in
simplify_cfg(noir-lang/noir#9276)chore: Update noir-lang/sparse_array failures status (noir-lang/noir#9289)
chore: Mark
sparse_arrayandnoir_json_parseras non-critical (noir-lang/noir#9282)fix: Use
u32inRepeatedValueexample in generics docs (noir-lang/noir#9273)chore!: enforce visibility warnings as errors (noir-lang/noir#7657)
Commit
60222bb380da2c6840adb91317bee2ca4db30d2acauses failing tests so could not sync Noir beyondb28776c8a68dbc319e2ffcee350b8e2a71b20096(relevant slack discussion here).