fix: use powers of beta for batching columns in logup #19881
Conversation
| { T(0), T(0), T(0), T(0), T(0) }, | ||
| { T(0), T(0), T(0), T(0), T(0) } } }; | ||
|
|
||
| RefArray<T, NUM_TO_FOLD> get_to_fold() |
There was a problem hiding this comment.
this file is a mess
ledwards2225
left a comment
ledwards2225
left a comment
There was a problem hiding this comment.
LGTM - would be nice to avoid the sol formatting issues or figure out why they're happening
| and(precomp_success_flag, staticcall(gas(), 7, G1_LOCATION, 0x60, ACCUMULATOR_2, 0x40)) | ||
| precomp_success_flag := | ||
| and(precomp_success_flag, staticcall(gas(), 6, ACCUMULATOR, 0x80, ACCUMULATOR, 0x40)) | ||
| precomp_success_flag := and( |
There was a problem hiding this comment.
The majority of this is just formatting? any idea why this is happening?
There was a problem hiding this comment.
it's likely that at some point I introduced some changes manually
| @@ -143,19 +143,17 @@ template <IsUltraOrMegaHonk Flavor> void OinkProver<Flavor>::execute_wire_commit | |||
| template <IsUltraOrMegaHonk Flavor> void OinkProver<Flavor>::execute_sorted_list_accumulator_round() | |||
There was a problem hiding this comment.
Its crazy that this is still the name of this round
There was a problem hiding this comment.
yeah, I'll clean up the naming + stuff like IsUltraOrMegaHonk in follow-ups
| domain_separator + "eta", domain_separator + "eta_two", domain_separator + "eta_three" }); | ||
| // Get eta challenge and compute powers (eta, eta², eta³) | ||
| FF eta = transcript->template get_challenge<FF>("eta"); | ||
| prover_instance->relation_parameters.eta = eta; |
There was a problem hiding this comment.
could just pass eta here and set them all at once
Add CLAUDE.md with development documentation for the Solidity Honk verifier including architecture overview, regeneration scripts, debugging workflow, and common troubleshooting steps. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
iakovenkos
changed the title
fix re-using eta in logup terms, use powers of gamma instead