feat(Barretenberg): acir<->bb tool: HN::INIT opcode validator - #25004
Open
DanielKotov wants to merge 2 commits into
Open
feat(Barretenberg): acir<->bb tool: HN::INIT opcode validator#25004DanielKotov wants to merge 2 commits into
DanielKotov wants to merge 2 commits into
Conversation
HNInitValidation.hpp self-nests under namespace HNVerification (same pattern as HNFinalValidation.hpp) instead of relying on hypernova_verification.hpp textually including it. No call-site changes needed: existing callers already use the fully-qualified HNVerification::HNInitValidation:: path.
…alidation HNInitValidation.hpp has HNVerification::validate_hn_init (both overloads) and the HNInitValidationResult alias defined at HNVerification scope, after the nested HNInitValidation namespace closes -- not inside HNInitValidation itself. Closing HNVerification too early left these at global scope.
DanielKotov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for HN::INIT opcode validator