fix(bb): guard component analyzer range-list mapping - #25020
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The nightly barretenberg debug build is failing in
acir_components_check_tests AcirComponentsCheckTest.DetectsUnconstrainedWitnesseswith_GLIBCXX_DEBUGaborting onstd::vector<unsigned int>::operator[]: witness/range-list index10is read from areal_variable_indexvector resized to 9 entries.Root cause: the component checker deliberately simulates a missing witness mapping by shrinking
builder.real_variable_index, but the circuit static analyzer and the checker range-list collection still assumed every variable index in range-list metadata could be mapped throughreal_variable_index. Release builds did not catch this, while the debug STL correctly aborted before the checker could return its intendedUNCONSTRAINEDerror.This PR:
to_real()to_real()tolerate stale builder variable references by mapping them tozero_idx()ComponentsCheckerso missing witnesses remain reported as unconstrained instead of crashingCI evidence:
http://ci.aztec-labs.com/32410024cc115505from runhttps://github.com/AztecProtocol/barretenberg-claude/actions/runs/30333232782.Tests
NATIVE_PRESET=debug AVM=0 AVM_TRANSPILER=0 cmake --build --preset debug --target acir_components_check_testsNATIVE_PRESET=debug AVM=0 AVM_TRANSPILER=0 scripts/run_test.sh acir_components_check_tests AcirComponentsCheckTest.DetectsUnconstrainedWitnesses./build-debug/bin/acir_components_check_testscmake --build --preset debug --target boomerang_value_detection_tests./build-debug/bin/boomerang_value_detection_testsgit diff --checkCreated by claudebox · group:
slackbot