chore: remove noisy 'Reconciling' debug log from prover node session manager - #25059
Draft
AztecBot wants to merge 1 commit into
Draft
chore: remove noisy 'Reconciling' debug log from prover node session manager#25059AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
AztecBot
added
ci-draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SessionManager.reconcileloggedReconcilingon every invocation. Reconcile is scheduled from every L2BlockStream event, every periodic tick, and everystartProofRPC, so on a prover node this fires constantly and floods debug-level logs without saying anything useful — the interesting outcomes (sessions opened, sessions skipped, sessions exiting) are already logged individually further down the same path.Removes the single
this.log.debug('Reconciling', { trigger })line. No behavior change;triggeris still used by the rest of the method.Requested by Phil Windle in #team-alpha.
Created by claudebox · group:
slackbot· requested by Phil Windle · Slack thread