bot #551
bot #551
Conversation
| # ============================================================================= | ||
|
|
||
| # --- Discord --- | ||
| bot_token = "${{ secrets.BOT_TOKEN }}" |
There was a problem hiding this comment.
I am seeing that is best practice to access secrets through shell variables rather than the secrets directly. When accessing secrets directly in run, there is a risk that the secrets get dumped in logs unintentionally.
There was a problem hiding this comment.
From what I've seen they get sanitized if printed, but I'll change it to meet best practices
|
|
||
| ### Local Development with DynamoDB | ||
|
|
||
| For local development, you can use DynamoDB Local, which is provided by AWS as a downloadable version that simulates the DynamoDB service. |
There was a problem hiding this comment.
Does this copy the database to the local machine?
There was a problem hiding this comment.
No, it just uses a local db. Copying would be a nice thing to do yeah. I'll look into it, I've done it ages ago so I def need a refresher
|
|
||
| # Sparta Rollup Tools | ||
|
|
||
| This repository contains tools for interacting with the Sparta Rollup, including a subgraph for The Graph and scripts for querying committee membership. |
There was a problem hiding this comment.
AI wrote this lol. It's very outdated actually, there's no subgraph anymore and etc. Needs updating
There was a problem hiding this comment.
A few questions:
- Should this page include some docs about the API endpoints?
- did you add a command that allows approved users to add themselves to the set?
- Can you add some instructions about the intended flow for someone to update this? If someone on the team wants to add a command, what is the intended workflow?
There was a problem hiding this comment.
Docs on the API endpoints are autogenerated in /api/docs once you run the service... Not sure if they're needed in the readme. Same for adding themselves to the set, you can just use the API page (swagger).
But for the instructions yeah I can add some instructions, this is terraform and everything runs correctly with just terraform apply --var-file <var-file> but it assumes whoever is updating it understands basics on terraform
|
No testing for now 😬 the reason I haven't invested too much in tests is just that requirements change so much, I'd just be having double trouble. But it may just be the time to add some proper testing yeah |
No description provided.