chore: update the prover cost component #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Apr 29, 2025
Fixes #13600. Accompanying update tohe engineering design in AztecProtocol/engineering-designs#59 The diff looks very large, but is mostly because we generated a new fixture structure.
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Apr 29, 2025
Fixes #13600. Accompanying update tohe engineering design in AztecProtocol/engineering-designs#59 The diff looks very large, but is mostly because we generated a new fixture structure.
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Apr 29, 2025
Fixes #13600. Accompanying update tohe engineering design in AztecProtocol/engineering-designs#59 The diff looks very large, but is mostly because we generated a new fixture structure.
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Apr 30, 2025
Fixes #13600. Accompanying update tohe engineering design in AztecProtocol/engineering-designs#59 The diff looks very large, but is mostly because we generated a new fixture structure.
just-mitch
reviewed
May 5, 2025
| - `L2_SLOTS_PER_L2_EPOCH` - the number of L2 slots in each L2 epoch (e.g. 32) | ||
| - `L1_GAS_PER_BLOCK_PROPOSAL` - the amount of L1 gas required to propose an L2 block on L1 (e.g. 0.2e6) | ||
| - `L1_GAS_PER_EPOCH_VERIFICATION` - the amount of L1 gas required to verify an L2 epoch on L1 (e.g. 1e6) | ||
| - `MAXIMUM_FEE_PER_EPOCH_PROOF_QUOTE` - the maximum basis point fee a prover can submit for an epoch proof quote (e.g. 9000) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AztecProtocol/aztec-packages#12764 and AztecProtocol/aztec-packages#13599
Related implementation in AztecProtocol/aztec-packages#13833
Updates the notebook to use marimo instead (this makes futere changes simpler to review since the notebook is general python file instead of the janky json that we get from jypyter.
The change is fairly simple actually, we will earlier make a split between the prover and sequencer fees, and then instead of just storing the proving cost, we store the overall prover costs.