Skip to content

chore: standardize terminology across the codebase #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: standardize terminology across the codebase #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/alt-model/send/send_form_composer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export class SendComposer {
targetAmount.toAssetValue(),
feeAmount.toAssetValue(),
recipient.userId,
true, // recipientAccountRequired: (transfering to an account that is registered)
true, // recipientAccountRequired: (transferring to an account that is registered)
);
} else {
controller = sdk.createWithdrawController(
Expand Down
2 changes: 1 addition & 1 deletion src/alt-model/shield/shielding_gas_estimate_hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ async function getDepositFundsGasEstimate(contract: Contract, fromAddressStr: st
// in the fallback values.
return 70000n;

// // A non-zero value indicates some token is has to be transfered
// // A non-zero value indicates some token is has to be transferred
// const ethValue = assetId === 0 ? 1n : 0n;
// const tokenValue = assetId === 0 ? 0n : 1n;
// const proofHash = TxId.random().toString();
Expand Down