"improved" ordering of tags and pipe colors #1145
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technici4n
reviewed
Jul 22, 2025
| public class TagsToGenerate { | ||
|
|
||
| static final Map<TagKey<Item>, List<ItemLike>> tagToItemMap = new HashMap<>(); | ||
| static final Map<ItemLike, SortOrder> itemSortOrderMap = new HashMap<>(); |
There was a problem hiding this comment.
The key should be Item not ItemLike, otherwise it might not be found in the map if queried with a different ItemLike that has the same Item.
Technici4n
reviewed
Jul 22, 2025
| public static void generateTagNoTranslation(TagKey<Item> tag, ItemLike item, SortOrder sortOrder) { | ||
| tagToItemMap.computeIfAbsent(tag, t -> new ArrayList<>()).add(item); | ||
| if (sortOrder != null) { | ||
| itemSortOrderMap.put(item, sortOrder); |
Technici4n
reviewed
Jul 22, 2025
| generateTagNoTranslation(tag, item, null); | ||
| } | ||
|
|
||
| public static void generateTagNoTranslation(TagKey<Item> tag, ItemLike item, SortOrder sortOrder) { |
There was a problem hiding this comment.
Make the param @nullable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
results:
