Skip to content

OIDC Ui Test Automation #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Oct 8, 2024
Merged

OIDC Ui Test Automation #791

merged 28 commits into from
Oct 8, 2024

Conversation

JoshLozensky
Copy link
Contributor

@JoshLozensky JoshLozensky commented Sep 28, 2024

Currently the only issue keeping this a draft PR is I'm not sure how to get the sample to use the appsettings.json file in the test folder rather than the one in the sample folder. Otherwise, the test works.

In the UiTestHelpers file only lines 458 to 532 are truly new as the rest of the file came from the Id Web repo.

@JoshLozensky JoshLozensky marked this pull request as ready for review October 4, 2024 22:10
JoshLozensky and others added 2 commits October 7, 2024 16:25
Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
Copy link
Contributor

@westin-m westin-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some questions and suggestions, none of them blocking

JoshLozensky and others added 8 commits October 7, 2024 17:03
Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
@JoshLozensky JoshLozensky merged commit 3753b78 into master Oct 8, 2024
2 checks passed
@JoshLozensky JoshLozensky deleted the lozenksy/AddingUiTests branch October 8, 2024 00:44
@jennyf19
Copy link
Contributor

jennyf19 commented Oct 8, 2024

great progress @JoshLozensky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants