Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra code for sample #2

Merged
merged 10 commits into from
Oct 21, 2024
Merged

Infra code for sample #2

merged 10 commits into from
Oct 21, 2024

Conversation

jmatthiesen
Copy link
Contributor

Purpose

This pull request includes several changes to the infrastructure and configuration files to support new features and improve deployment processes. The most important changes include adding post-provision hooks, introducing a flag for role creation, updating role assignments, and adding new deployment configurations.

Infrastructure Enhancements:

  • Added post-provision hooks for both Windows and POSIX environments in azure.yaml to set connection strings after provisioning. (services: in azure.yaml)
  • Introduced a flag createRoleForUser in infra/main.bicep to conditionally create OpenAI roles for the current user. (param location string in infra/main.bicep)
  • Updated role assignments in infra/openai/openai.module.bicep to include a conditional role assignment for users based on the new flag. (resource cognitiveServicesAccount_wXAGTFUId 'Microsoft.CognitiveServices/account in infra/openai/openai.module.bicep)

Configuration Updates:

  • Changed the default value for location in infra/main.parameters.json to eastus. (infra/main.parameters.json)
  • Added a new deployment configuration template for aichatapp-web in src/AIChatApp.AppHost/infra/aichatapp-web.tmpl.yaml to support managed identities and connection strings. (src/AIChatApp.AppHost/infra/aichatapp-web.tmpl.yaml)

Script Additions:

  • Added a PowerShell script set-connection-string.ps1 to initialize and set user secrets for connection strings. (infra/post-script/set-connection-string.ps1)

…s User role, so that the sample can be run after using azd provision/up.
@jmatthiesen jmatthiesen changed the base branch from newSample to main October 19, 2024 18:29
@jmatthiesen jmatthiesen marked this pull request as ready for review October 21, 2024 19:48
@jmatthiesen jmatthiesen merged commit 5ab3ea6 into main Oct 21, 2024
1 of 2 checks passed
@jmatthiesen jmatthiesen deleted the infraForSample branch October 21, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant