DNS samples#150
Open
joshgav wants to merge 2 commits into
Open
Conversation
mcardosos
reviewed
Mar 24, 2018
| "github.com/Azure-Samples/azure-sdk-for-go-samples/helpers" | ||
| "github.com/Azure-Samples/azure-sdk-for-go-samples/iam" | ||
|
|
||
| dns "github.com/Azure/azure-sdk-for-go/services/dns/mgmt/2017-09-01/dns" |
Contributor
There was a problem hiding this comment.
dns [](start = 1, length = 3)
dns is not needed
mcardosos
reviewed
Mar 24, 2018
| helpers.ResourceGroupName(), | ||
| zoneName, | ||
| dns.Zone{ | ||
| Location: to.StringPtr("global"), |
Contributor
There was a problem hiding this comment.
global [](start = 27, length = 6)
I dont know enough about the DNS service, exactly what dooes global mean in this context? Can't zones be created on westus?
There was a problem hiding this comment.
Dns is a global service so it doesn't really make sense to have a zone in a region. Is the parameter required ? it might be needed for private zones as those will be bound to a region.
mcardosos
suggested changes
Mar 24, 2018
mcardosos
left a comment
mcardosos
left a comment
Contributor
There was a problem hiding this comment.
CI is not passing, also it looks like this should be rebased
mcardosos
reviewed
Apr 21, 2018
| os.Exit(m.Run()) | ||
| } | ||
|
|
||
| func ExampleDnsZone() { |
Contributor
There was a problem hiding this comment.
Could this get a better name? More specific on what the sample is doing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #149 to update Gopkg.* files, then this PR adds one line to Gopkg.lock for the
dnspackage.closes #87
helps with Azure/azure-sdk-for-go#1161