Restore azure-functions dependency for Azure Functions apps #2895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the Ask/Q&A tab from the application as it was not widely used and duplicated functionality available in the Chat tab. Changes: - Remove Ask page frontend components (Ask.tsx, Ask.module.css) - Remove RetrieveThenReadApproach backend class - Remove /ask API endpoint - Remove Ask-related tests and snapshots - Update documentation to reflect removal - Update all translation files - Update evaluation configs Fixes Azure-Samples#2834
Deprecate Ask tab
The azure-functions package was accidentally removed from requirements.in in PR Azure-Samples#2835. This package is needed because the function apps (document_extractor, figure_processor, text_processor) use the same requirements.txt via the copy_prepdocslib.py script, and they require azure-functions for the Azure Functions runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The
azure-functionspackage was accidentally removed fromrequirements.inin PR #2835. This package is required because the Azure Function apps (document_extractor, figure_processor, text_processor) reuse the backend'srequirements.txtvia thecopy_prepdocslib.pyscript, and they need theazure-functionspackage for the Azure Functions runtime (import azure.functions as func).Does this introduce a breaking change?
Does this require changes to learn.microsoft.com docs?
Type of change
Code quality checklist
See CONTRIBUTING.md for more details.
python -m pytest).python -m pytest --covto verify 100% coverage of added linespython -m mypyto check for type errorsruffandblackmanually on my code.