remove unused import, removed commneted out code, and add return types

Azure-Samples · Jan 16, 2025 · 52d8017 · 52d8017
1 parent 2e3f267
commit 52d8017
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 12 deletions.
diff --git a/client/src/components/teams/TeamsMeetingExperience.test.tsx b/client/src/components/teams/TeamsMeetingExperience.test.tsx
@@ -2,7 +2,7 @@
 // Licensed under the MIT license.
 
 import { createAzureCommunicationCallWithChatAdapterFromClients } from '@azure/communication-react';
-import { prettyDOM, render } from '@testing-library/react';
+import { render } from '@testing-library/react';
 import { PostCallConfig } from '../../models/ConfigModel';
 import * as GetTeamsMeetingLink from '../../utils/GetMeetingLink';
 import {
@@ -87,15 +87,6 @@ describe('TeamsMeetingExperience', () => {
     await runFakeTimers();
     const callWithChatComposites = meetingExperience.queryAllByTestId('meeting-composite');
     expect(callWithChatComposites.length).toBe(1);
-    // expect(callWithChatComposites[0].props().locale?.strings.call.lobbyScreenWaitingToBeAdmittedTitle).toBe(
-    //   waitingTitle
-    // );
-    // expect(callWithChatComposites.first().props().locale?.strings.call.lobbyScreenWaitingToBeAdmittedMoreDetails).toBe(
-    //   waitingSubtitle
-    // );
-    // expect(callWithChatComposites.first().props().icons?.LobbyScreenConnectingToCall).toBeDefined();
-    // expect(callWithChatComposites.first().props().icons?.LobbyScreenWaitingToBeAdmitted).toBeDefined();
-    // expect(callWithChatComposites.first().props().formFactor).toEqual('desktop');
   });
 
   it('sets the formFactor to mobile in the CallWithChatComposite', async () => {

diff --git a/server/src/controllers/roomsController.test.ts b/server/src/controllers/roomsController.test.ts
@@ -23,7 +23,7 @@ describe('roomsController', () => {
   const expectedPresenterId = 'communicationUserId-presenter';
   const expectedAttendeeId = 'communicationUserId-attendee';
 
-  function createPartipantsIterator() {
+  function createPartipantsIterator(): Iterable<RoomParticipant> {
     let nextIndex = 0;
     const participants = [
       {
@@ -49,6 +49,9 @@ describe('roomsController', () => {
           return result;
         }
         return { value: undefined, done: true };
+      },
+      [Symbol.iterator]: function () {
+        return this;
       }
     };
     return rangeIterator;

diff --git a/server/src/controllers/roomsController.ts b/server/src/controllers/roomsController.ts
@@ -140,7 +140,7 @@ export const getToken = (identityClient: CommunicationIdentityClient, roomsClien
   }
 };
 
-async function toArray(asyncIterator) {
+async function toArray(asyncIterator): Promise<RoomParticipant[]> {
   const arr: RoomParticipant[] = [];
   let result = await asyncIterator.next();
   while (result.value) {