Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions property to publish-nightly-build.yml and publish-release-artifacts.yml #195

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

mgamis-msft
Copy link
Contributor

What

Add permissions property to publish-nightly-build.yml and publish-release-artifacts.yml so that Github bot is able to push tags

Why

To avoid errors like the shown the following failed run when pushing tags:
https://github.com/Azure-Samples/communication-services-virtual-visits-js/actions/runs/12838635528/job/35804585065

How Tested

Confirmed to work in this run of the workflow:
https://github.com/Azure-Samples/communication-services-virtual-visits-js/actions/runs/12839133594

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Does this PR contain ARM Template changes?

  • I have verified deploying using the ARM Template
  • I have tested the deployed app end to end

Is this a breaking change?

  • This change causes current functionality to break.

@mgamis-msft mgamis-msft merged commit ce03615 into main Jan 21, 2025
4 checks passed
@mgamis-msft mgamis-msft deleted the mgamis/update-permissions-to-publishing-workflows branch January 21, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants