Update Calling Hero to the Latest version #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carocao-msft
requested review from
alkwa-msft,
JamesBurnside,
mgamis-msft,
dmceachernmsft,
prabhjot-msft and
edwardlee-msft
as code owners
Calling/src/index.tsx
Outdated
| @@ -19,3 +19,4 @@ createRoot(domNode).render( | |||
| </SwitchableFluentThemeProvider> | |||
| </React.StrictMode> | |||
| ); | |||
| export {}; /*The above line is generated by conditional compilation, when no export detected after CC.*/ | |||
Calling/public/index.html
Outdated
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <meta name="description" content="Azure Communication Services - UI Library: Calling Sample app" /> | ||
| <title>UI Library Calling Sample</title> | ||
|
|
There was a problem hiding this comment.
please remove this as its for render tracker a debugging tool we don't provide in the hero
Calling/src/app/App.tsx
Outdated
| @@ -93,6 +93,7 @@ const App = (): JSX.Element => { | |||
| getMeetingIdFromUrl() || | |||
| getGroupIdFromUrl() || | |||
| createGroupId(); | |||
|
|
|||
There was a problem hiding this comment.
please remove the new lines generated by CC code
mgamis-msft
reviewed
Jan 17, 2025
| @@ -27,3 +27,4 @@ describe('ContosoUtils tests', () => { | |||
| test('createRandomDisplayName should return a valid string for a user id', () => | |||
| expect(createRandomDisplayName()).toBeTruthy()); | |||
| }); | |||
| export {}; /*The above line is generated by conditional compilation, when no export detected after CC.*/ | |||
There was a problem hiding this comment.
Please remove this line as well
mgamis-msft
reviewed
Jan 17, 2025
Calling/src/app/utils/AppUtils.ts
Outdated
| @@ -14,7 +14,7 @@ import { v1 as generateGUID } from 'uuid'; | |||
| export const fetchTokenResponse = async (): Promise<any> => { | |||
| const response = await fetch('token?scope=voip'); | |||
| if (response.ok) { | |||
| const responseAsJson = await response.json(); | |||
| const responseAsJson = await response.json(); //(await response.json())?.value?.token; | |||
There was a problem hiding this comment.
Also remove the commented out code here
mgamis-msft
approved these changes
Jan 17, 2025
dmceachernmsft
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update Calling Hero to the Latest version 1.23.0
Pull Request Type
Upstream sample reference
Links to PR(s) that made the original change in the upstream sample:
How to Test
What to Check
Verify that the following are valid
Other Information