Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable mic / camera button functionality based on capabilities with tool tip #204

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

elavarasidc
Copy link
Contributor

@elavarasidc elavarasidc commented Dec 2, 2023

Purpose

  1. Disable mic / camera button functionality based on capabilities with an appropriate tool Tip. [So far, the UI reflected capability, but clicking on the component still resulted in the functionality such as turnVideoOn].

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce? Reflect permissions on UI components

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@elavarasidc
Copy link
Contributor Author

@sharifrahaman please help review.

@elavarasidc elavarasidc marked this pull request as draft December 2, 2023 04:30
@elavarasidc
Copy link
Contributor Author

elavarasidc commented Dec 20, 2023

image

  1. disable and not able to click - worked.
  2. Title - to reflect restriction - not working - cannot flush updates when react is ready and rendering.
  3. rooms - role update seems busted in general. All testing above is from teams meeting - checking with team.
  4. The share screen icon needs to be fixed. It is not visible at all - wip

@elavarasidc
Copy link
Contributor Author

image

title={!this.state.canOnVideo ? No permission to turn on video : Turn your video ${this.state.videoOn ? 'off' : 'on'}}

@elavarasidc elavarasidc marked this pull request as ready for review December 20, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant