Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic when video off and user can turn on video #259

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

fuyan2024
Copy link
Contributor

@fuyan2024 fuyan2024 commented Feb 6, 2025

Purpose

  • ...

This PR to fix logic showing video off icon when user can turn on video.
There is an existing problem that videoOff2 icon is not working from CDN, that is separate issue.

Problem: when user has video off and user cannot turn on video, we showed two icons:
image

Fix is to show one of the 3 icons depending on states.
1.this.state.canOnVideo && this.state.videoOn
image

  1. this.state.canOnVideo && !this.state.videoOn
    image

3.!this.state.canOnVideo
image

Does this introduce a breaking change?

[ ] Yes
[ x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code

1.When user has video on:
image

  1. When user has video off, can turn on video himself, there is an existing problem with the VideoOff2 icon.
    image

  2. When user hard muted and can not turn on video
    image

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@fuyan2024 fuyan2024 merged commit 67ab825 into main Feb 6, 2025
3 checks passed
@fuyan2024 fuyan2024 deleted the fuyan/fix-logic-video-off branch February 6, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants