Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for default selection with azd up #247

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

vhvb1989
Copy link
Contributor

@vhvb1989 vhvb1989 commented Feb 11, 2025

This template is referenced at the top of the AI-templates site and from the main 3 reference templates for coding in the AI Foundry portal.

However, running azd up and accepting whatever is the default location from the user is most likely to fail!, Leading customers into disappointment.

This PR bring the initial changes for the infrastructure to make it work again. The changes to the sample api are still pending.

Infra changes:

  • Update deployment gpt-35-turbo to gpt-4o-mini
  • Removing model gpt-4-evals -> Not sure what model to use to replace this one....
  • Updating hub.bicep connection to AIServices instead of AzureOpenAI -> Not sure if this is a breaking change...
  • Updating main.bicep with the list of locations that supports Foundry projects + semantic ranker + content safety
  • Removing bicepparams file and using main.parameters.json to leverage azd's prompt for location (not supported from bicepparam).

Missing changes:

  • Full update to README doc to reference gpt-4o-mini and consolidate the repository name. I think it is contoso-chat, but there are references to contoso-chat-openai-prompty

@nitya
Copy link
Collaborator

nitya commented Feb 13, 2025

Thanks @vhvb1989 - testing now.

Copy link
Collaborator

@nitya nitya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploys successfully but requires additional updates.
Merging this PR first and will add updates next.

@nitya nitya marked this pull request as ready for review February 26, 2025 23:13
@nitya nitya merged commit 69200cb into Azure-Samples:main Feb 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants