Update generic git sample with simplified approach #1198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the generic Git sample by simplifying the approach for managing Fabric items and enhancing the documentation. Key changes include:
- Adding detailed usage instructions for the simplified scripts (download/push).
- Introducing comprehensive CI/CD documentation with setup steps and error troubleshooting.
- Updating the README to clarify the supported Git providers and token generation methods.
Reviewed Changes
Copilot reviewed 6 out of 16 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| single_tech_samples/fabric/fabric_cicd_gitlab/docs/simplified_approach.md | Added usage instructions and prerequisite information for simplified update scripts. |
| single_tech_samples/fabric/fabric_cicd_gitlab/docs/full_cicd_approach.md | Introduced comprehensive CI/CD approach documentation with detailed steps and troubleshooting tips. |
| single_tech_samples/fabric/fabric_cicd_gitlab/README.md | Revised introduction and set-up instructions to better reflect the simplified and comprehensive approaches. |
Files not reviewed (10)
- single_tech_samples/fabric/fabric_cicd_gitlab/config/.envtemplate: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/new_branch.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/params.psd1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/refresh_api_token.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/simplified_update_item_from_git.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/simplified_update_item_from_ws.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_git_to_ws.ps1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_git_to_ws.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_ws_to_git.ps1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/utilities.sh: Language not supported
Comments suppressed due to low confidence (1)
single_tech_samples/fabric/fabric_cicd_gitlab/docs/full_cicd_approach.md:23
- The word 'defintion' is misspelled. It should be 'definition'.
All Fabric items come with a minimal defintion (at the time of writing comprising of Name, Type and Description).
single_tech_samples/fabric/fabric_cicd_gitlab/docs/full_cicd_approach.md
Outdated
Show resolved
Hide resolved
single_tech_samples/fabric/fabric_cicd_gitlab/docs/full_cicd_approach.md
Outdated
Show resolved
Hide resolved
…pproach.md Co-authored-by: Copilot <[email protected]>
…neric-git-sample' of https://github.com/Azure-Samples/modern-data-warehouse-dataops into elena/update-generic-git-sample
There was a problem hiding this comment.
Pull Request Overview
This PR introduces documentation updates for a simplified approach to manage Microsoft Fabric items and refines the comprehensive CI/CD approach documentation. Key changes include:
- Addition of a new simplified approach document detailing usage instructions and prerequisites.
- Introduction of a comprehensive README update that clarifies the scenarios and workflow for multi-tenancy and generic Git providers.
- Improvements in the comprehensive CI/CD documentation to outline error handling and PowerShell script usage.
Reviewed Changes
Copilot reviewed 6 out of 16 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| single_tech_samples/fabric/fabric_cicd_gitlab/docs/simplified_approach.md | New documentation outlining a simplified approach for pulling/pushing Fabric items. |
| single_tech_samples/fabric/fabric_cicd_gitlab/docs/full_cicd_approach.md | Added comprehensive CI/CD documentation detailing workflow, error scenarios, and usage instructions. |
| single_tech_samples/fabric/fabric_cicd_gitlab/README.md | Updated the README to clearly differentiate between the simplified and comprehensive approaches and correct phrasing around multi-tenancy and git providers. |
Files not reviewed (10)
- single_tech_samples/fabric/fabric_cicd_gitlab/config/.envtemplate: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/new_branch.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/params.psd1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/refresh_api_token.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/simplified_update_item_from_git.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/simplified_update_item_from_ws.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_git_to_ws.ps1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_git_to_ws.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_ws_to_git.ps1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/utilities.sh: Language not supported
single_tech_samples/fabric/fabric_cicd_gitlab/docs/full_cicd_approach.md
Outdated
Show resolved
Hide resolved
…pproach.md Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the generic git sample documentation by adding a simplified approach for Fabric item updates and enhancing the comprehensive CI/CD instructions.
- Added detailed usage instructions for the simplified update scripts.
- Introduced a comprehensive guide for CI/CD integration with Fabric using REST APIs.
- Revised the README to better clarify the two approaches and improve overall documentation consistency.
Reviewed Changes
Copilot reviewed 6 out of 16 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| single_tech_samples/fabric/fabric_cicd_gitlab/docs/simplified_approach.md | Added detailed instructions for using simplified update scripts. |
| single_tech_samples/fabric/fabric_cicd_gitlab/docs/full_cicd_approach.md | Provided comprehensive CI/CD strategy and troubleshooting steps. |
| single_tech_samples/fabric/fabric_cicd_gitlab/README.md | Revised introductory content and clarified sample approach options. |
Files not reviewed (10)
- single_tech_samples/fabric/fabric_cicd_gitlab/config/.envtemplate: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/new_branch.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/params.psd1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/refresh_api_token.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/simplified_update_item_from_git.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/simplified_update_item_from_ws.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_git_to_ws.ps1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_git_to_ws.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_ws_to_git.ps1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/utilities.sh: Language not supported
single_tech_samples/fabric/fabric_cicd_gitlab/docs/full_cicd_approach.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the generic git sample to introduce a simplified approach for handling Fabric items along with improvements and additional documentation for the comprehensive CI/CD approach. Key changes include:
- Adding detailed usage instructions for the simplified Fabric scripts.
- Introducing comprehensive documentation for a CI/CD workflow using both Bash and PowerShell.
- Updating the README to clarify the two approaches and their intended use cases.
Reviewed Changes
Copilot reviewed 6 out of 16 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| single_tech_samples/fabric/fabric_cicd_gitlab/docs/simplified_approach.md | New document detailing the simplified Fabric update and push scripts. |
| single_tech_samples/fabric/fabric_cicd_gitlab/docs/full_cicd_approach.md | Comprehensive documentation outlining the CI/CD process and repository structure. |
| single_tech_samples/fabric/fabric_cicd_gitlab/README.md | Revised introduction and instructions to differentiate between simplified and comprehensive approaches. |
Files not reviewed (10)
- single_tech_samples/fabric/fabric_cicd_gitlab/config/.envtemplate: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/new_branch.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/params.psd1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/refresh_api_token.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/simplified_update_item_from_git.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/simplified_update_item_from_ws.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_git_to_ws.ps1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_git_to_ws.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_ws_to_git.ps1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/utilities.sh: Language not supported
There was a problem hiding this comment.
Pull Request Overview
This PR updates the generic git sample documentation to introduce a simplified approach for managing Fabric item updates and further refines the comprehensive CI/CD approach. The changes include adding detailed usage instructions and updating the README to clearly distinguish between the two approaches.
- Added a simplified approach with step-by-step instructions for downloading and pushing Fabric items.
- Enhanced and clarified documentation for the comprehensive CI/CD approach.
- Updated the README to better explain the two available approaches and their appropriate use cases.
Reviewed Changes
Copilot reviewed 6 out of 16 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| single_tech_samples/fabric/fabric_cicd_gitlab/docs/simplified_approach.md | New documentation providing usage instructions for the simplified approach, including prerequisites and example usage. |
| single_tech_samples/fabric/fabric_cicd_gitlab/docs/full_cicd_approach.md | Expanded documentation detailing the comprehensive CI/CD approach with clear step-by-step guidance and error handling. |
| single_tech_samples/fabric/fabric_cicd_gitlab/README.md | Updated introductory text and structure to distinguish between the two approaches, enhancing overall clarity. |
Files not reviewed (10)
- single_tech_samples/fabric/fabric_cicd_gitlab/config/.envtemplate: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/new_branch.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/params.psd1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/refresh_api_token.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/simplified_update_item_from_git.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/simplified_update_item_from_ws.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_git_to_ws.ps1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_git_to_ws.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_ws_to_git.ps1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/utilities.sh: Language not supported
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the generic git sample for Microsoft Fabric by adding a simplified approach for managing Fabric items and improving the comprehensive approach documentation, along with various clarifications in the README.
- Added detailed usage instructions for the simplified approach scripts.
- Expanded and refined documentation for the comprehensive CI/CD approach.
- Updated the README to clearly differentiate between the two approaches and improve overall clarity.
Reviewed Changes
Copilot reviewed 6 out of 16 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| single_tech_samples/fabric/fabric_cicd_gitlab/docs/simplified_approach.md | Introduces the simplified approach and its usage instructions. |
| single_tech_samples/fabric/fabric_cicd_gitlab/docs/full_cicd_approach.md | Provides a comprehensive overview of the CI/CD process using Fabric REST APIs. |
| single_tech_samples/fabric/fabric_cicd_gitlab/README.md | Updates the introductory content and instructions to align with the new approaches. |
Files not reviewed (10)
- single_tech_samples/fabric/fabric_cicd_gitlab/config/.envtemplate: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/new_branch.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/params.psd1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/refresh_api_token.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/simplified_update_item_from_git.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/simplified_update_item_from_ws.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_git_to_ws.ps1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_git_to_ws.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_ws_to_git.ps1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/utilities.sh: Language not supported
Comments suppressed due to low confidence (1)
single_tech_samples/fabric/fabric_cicd_gitlab/docs/full_cicd_approach.md:207
- Consider adding a brief note that this error typically indicates the use of a PowerShell version earlier than 7, to guide users in resolving the issue.
Error response: A parameter cannot be found that matches parameter name 'ResponseHeadersVariable'
single_tech_samples/fabric/fabric_cicd_gitlab/docs/simplified_approach.md
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
…approach.md Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the generic git sample by introducing a simplified approach along with improvements to the comprehensive CI/CD documentation. Key changes include new usage instructions in the simplified approach documentation, an expanded explanation of the comprehensive CI/CD workflow, and a streamlined README that better outlines both approaches.
Reviewed Changes
Copilot reviewed 6 out of 16 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| single_tech_samples/fabric/fabric_cicd_gitlab/docs/simplified_approach.md | Added comprehensive usage instructions for the simplified update scripts and related prerequisites. |
| single_tech_samples/fabric/fabric_cicd_gitlab/docs/full_cicd_approach.md | Introduced detailed documentation on the full CI/CD process including authentication and deployment steps. |
| single_tech_samples/fabric/fabric_cicd_gitlab/README.md | Updated to reference the new simplified and comprehensive approaches and improved clarity of instructions. |
Files not reviewed (10)
- single_tech_samples/fabric/fabric_cicd_gitlab/config/.envtemplate: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/new_branch.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/params.psd1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/refresh_api_token.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/simplified_update_item_from_git.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/simplified_update_item_from_ws.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_git_to_ws.ps1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_git_to_ws.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_ws_to_git.ps1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/utilities.sh: Language not supported
single_tech_samples/fabric/fabric_cicd_gitlab/docs/simplified_approach.md
Show resolved
Hide resolved
single_tech_samples/fabric/fabric_cicd_gitlab/docs/full_cicd_approach.md
Outdated
Show resolved
Hide resolved
…pproach.md Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the generic Git sample for Fabric by introducing a simplified approach for updating Fabric items via scripts and by refining the comprehensive CI/CD documentation.
- Added a new documentation file (simplified_approach.md) that details usage instructions for the simplified scripts.
- Introduced a comprehensive guide (full_cicd_approach.md) outlining a full CI/CD process with Fabric, including REST API usage and PowerShell script instructions.
- Updated the main README to clearly differentiate between the two approaches and to improve configuration file naming consistency.
Reviewed Changes
Copilot reviewed 6 out of 16 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| single_tech_samples/fabric/fabric_cicd_gitlab/docs/simplified_approach.md | New documentation for the simplified update scripts. |
| single_tech_samples/fabric/fabric_cicd_gitlab/docs/full_cicd_approach.md | New documentation for the comprehensive CI/CD approach with detailed process steps. |
| single_tech_samples/fabric/fabric_cicd_gitlab/README.md | Revised introduction and configuration instructions for clarity and consistency. |
Files not reviewed (10)
- single_tech_samples/fabric/fabric_cicd_gitlab/config/.envtemplate: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/new_branch.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/params.psd1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/refresh_api_token.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/simplified_update_item_from_git.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/simplified_update_item_from_ws.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_git_to_ws.ps1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_git_to_ws.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_ws_to_git.ps1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/utilities.sh: Language not supported
Comments suppressed due to low confidence (1)
single_tech_samples/fabric/fabric_cicd_gitlab/README.md:55
- Ensure that the configuration file names referenced throughout the documentation are consistent. For instance, if the simplified approach uses '.env', consider updating all related sections to avoid confusion with references to 'params.psd1'.
This will copy the token to your clipboard. You can then paste its value in the `.env` file.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the generic Git sample with a simplified approach and enhances the comprehensive CI/CD documentation for Microsoft Fabric integrations. The key changes include:
- Adding detailed usage instructions for the simplified approach to pulling/pushing changes from/to Fabric.
- Expanding the comprehensive approach documentation with step‑by‑step setup instructions and troubleshooting details.
- Updating the README to clarify configuration file usage and align content with the new samples.
Reviewed Changes
Copilot reviewed 6 out of 16 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| single_tech_samples/fabric/fabric_cicd_gitlab/docs/simplified_approach.md | Introduces and explains the simplified update scripts with detailed prerequisites and usage examples. |
| single_tech_samples/fabric/fabric_cicd_gitlab/docs/full_cicd_approach.md | Provides an in‑depth description of the comprehensive CI/CD approach using Fabric REST APIs and PowerShell scripts. |
| single_tech_samples/fabric/fabric_cicd_gitlab/README.md | Updates the sample introduction and configuration instructions for clearer guidance between simplified and comprehensive approaches. |
Files not reviewed (10)
- single_tech_samples/fabric/fabric_cicd_gitlab/config/.envtemplate: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/new_branch.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/params.psd1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/refresh_api_token.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/simplified_update_item_from_git.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/simplified_update_item_from_ws.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_git_to_ws.ps1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_git_to_ws.sh: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/update_from_ws_to_git.ps1: Language not supported
- single_tech_samples/fabric/fabric_cicd_gitlab/src/utilities.sh: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Purpose
Does this introduce a breaking change? If yes, details on what can break
No breaking changes introduced
Author pre-publish checklist
Validation steps
Issues Closed or Referenced