-
Notifications
You must be signed in to change notification settings - Fork 505
Databricks Sample - Terraform IaC for Azure Databricks and Asset Bundle Deployment via CI/CD #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@DilmurodMak - one of the validations is failing, can you take a look? |
@ydaponte , The pipeline are templates, it requires databricks workspaces exist and its urls are set in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving some comments that need to be addressed before we can merge into main. There are some best practices and alignment with the overall repo that will need to be done as for example the creation of a devcontainer for the sample. Thanks for the great work so far!
single_tech_samples/databricks/databricks_terraform/Infra/README.md
Outdated
Show resolved
Hide resolved
single_tech_samples/databricks/databricks_terraform/Infra/README.md
Outdated
Show resolved
Hide resolved
...mples/databricks/databricks_terraform/images/databricks-asset-bundle-deploymeny-pipeline.png
Outdated
Show resolved
Hide resolved
single_tech_samples/databricks/databricks_terraform/images/architecture.png
Outdated
Show resolved
Hide resolved
Co-authored-by: Yennifer Santos <[email protected]>
Co-authored-by: Yennifer Santos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't run the container - the req.txt file is missing. Can you upload it so I can further test? Thanks!
single_tech_samples/databricks/databricks_terraform/.devcontainer/Dockerfile
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving the comment as we discussed earlier today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that being on the account_unity_admin group is not working. Let's try to talk today. Tks!
single_tech_samples/databricks/databricks_terraform/Infra/deployment/dev.destroy.sh
Show resolved
Hide resolved
Co-authored-by: Yennifer Santos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Thanks for the great work!
Pull Request Overview
This PR updates and enhances the Databricks deployment process using Terraform and Asset Bundle Deployment via GitHub Actions. It simplifies deployment for multi environment deployment.
Key Highlights
single_tech_samples/databricks/databricks_terraform
generate-databricks-workflows.sh
.Testing Steps
The Sample code covers the deployment from sandbox to development environment.
main
.main
.