Fix Portal Deploy to Azure branch targets - #130
Merged
Conversation
Point the Portal Deploy to Azure links and linked-template base URI at main so the button loads the portal artifacts merged by PR #128 instead of stale portal/portalbicepalignment branch content. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This pull request updates customer-facing “Deploy to Azure” links and the portal template’s linked-template base URI so portal deployments consistently pull the merged deployment artifacts from the main branch (instead of older/staging branches).
Changes:
- Updated Deploy to Azure links in
README.mdto referencemain/portal/template.jsonandmain/portal/form.json. - Updated Deploy to Azure link in
PortalDeploymentGuide.mdto reference the samemainbranch artifacts. - Updated
portal/template.jsonbaseTemplateUrito resolve linked templates frommain/portal/.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Updates the Portal Deploy-to-Azure button to target main/portal/* artifacts. |
| PortalDeploymentGuide.md | Updates the documented Deploy-to-Azure button to target main/portal/* artifacts. |
| portal/template.json | Points baseTemplateUri at main/portal/ for linked-template resolution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Portal Deploy to Azure links and linked-template base URI to load the merged portal deployment artifacts from
maininstead of older or staging branches.Problem
PR #128 merged the updated Portal deployment artifacts into
main, but the Deploy to Azure buttons inREADME.mdandPortalDeploymentGuide.mdstill loadedportal/portal/template.jsonandportal/portal/form.json. In addition,portal/template.jsonresolved linked wrapper templates fromportalbicepalignment.This meant customer-facing deployments could continue loading stale branch content after the Portal/Bicep alignment work had merged.
Fix
README.mdandPortalDeploymentGuide.mdtomain/portal/template.jsonandmain/portal/form.json.portal/template.json'sbaseTemplateUritomain/portal/.Validation
portal/template.jsonandportal/form.jsonparse successfully as JSON.portalorportalbicepalignmentbranch references remain in the three changed files.mainbranch targets are present.