Skip to content

Reset host network state through binary reset during uninstall #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bcho merged 18 commits into from
Jun 26, 2026
Merged

Reset host network state through binary reset during uninstall #207

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
424267e
Initial plan
Copilot Jun 25, 2026
17b510d
Reset host network during uninstall
Copilot Jun 25, 2026
c230872
Harden WireGuard key cleanup
Copilot Jun 25, 2026
7df781e
Handle shred failures during uninstall
Copilot Jun 25, 2026
abd0f2e
Clarify network reset cleanup
Copilot Jun 25, 2026
725b1c1
Finalize network cleanup handling
Copilot Jun 25, 2026
af0e9d2
Address final cleanup review
Copilot Jun 25, 2026
5860cf8
Document network cleanup assumptions
Copilot Jun 25, 2026
3d42de5
Address network cleanup validation feedback
Copilot Jun 25, 2026
cd24e82
Document cleanup implementation details
Copilot Jun 25, 2026
715a3d8
Refine cleanup comments
Copilot Jun 25, 2026
5df6657
Move host network reset into binary
Copilot Jun 25, 2026
2e42ba1
Parallelize reset route cleanup
Copilot Jun 25, 2026
9efd611
Add e2e reset cleanup verification
Copilot Jun 25, 2026
2ebedf9
Adjust E2E reset network validation
Copilot Jun 25, 2026
952bcc3
Use portable wg interface validation
Copilot Jun 25, 2026
2a5eb25
Handle empty wg validation matches
Copilot Jun 25, 2026
6b214c9
Extract reset cleanup validation helpers
Copilot Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/daemon/reset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ func ResetNode(log *slog.Logger) phases.Task {
reset.CleanupMachine(log, goalstates.NSpawnMachineKube1),
reset.CleanupMachine(log, goalstates.NSpawnMachineKube2),
),
phases.Parallel(log,
Comment thread
bcho marked this conversation as resolved.
reset.RemoveNetworkInterfaces(log),
reset.RemoveWireGuardKeys(log),
),
reset.CleanupRoutes(log),
reset.ReloadSystemd(log),
config.RemoveRuntimeDirs(log),
Expand Down
6 changes: 4 additions & 2 deletions scripts/uninstall.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,10 @@ confirm_uninstall() {
echo "• Configuration directory ($CONFIG_DIR)"
echo "• Data directory ($DATA_DIR)"
echo "• Log directory ($LOG_DIR)"
echo "• Host network state created by unbounded-net"
echo "• Azure CLI"
echo ""
echo -e "${YELLOW}NOTE: This will first run 'aks-flex-node reset' to clean up cluster and Arc resources.${NC}"
echo -e "${YELLOW}NOTE: This will first run 'aks-flex-node reset' to clean up cluster, Arc, and host network resources.${NC}"
Comment thread
bcho marked this conversation as resolved.
echo ""

# Always prompt for confirmation, even when piped
Expand All @@ -66,7 +67,7 @@ confirm_uninstall() {
}

run_reset() {
log_info "Running reset to clean up cluster and Arc resources..."
log_info "Running reset to clean up cluster, Arc, and host network resources..."

# Check if aks-flex-node binary exists
if [[ ! -f "$INSTALL_DIR/aks-flex-node" ]]; then
Expand Down Expand Up @@ -183,6 +184,7 @@ show_completion_message() {
echo "✅ Service user and permissions"
echo "✅ Configuration and data directories"
echo "✅ Log files"
echo "✅ Host network state"
Comment thread
bcho marked this conversation as resolved.
echo "✅ Azure CLI"
echo ""
echo -e "${GREEN}Complete uninstallation finished!${NC}"
Expand Down