Open
Conversation
Copilot
AI
changed the title
[WIP] Fix node bootstrap failure on SELinux enforced host
Preserve SELinux labels for atomic file writes
Jul 7, 2026
Contributor
Author
bcho
approved these changes
Jul 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates pkg/utils/utilio atomic-write helpers to create renameio temporary files in the destination directory (rather than the system temp directory), preventing SELinux label mismatches on SELinux-enforcing hosts during bootstrap file installation.
Changes:
- Update
InstallFileWithLimitedSizeto createrenameiopending temp files infilepath.Dir(filename). - Update
WriteFileto passrenameio.WithTempDir(filepath.Dir(filename))torenameio.WriteFile. - Document the SELinux-label rationale in function comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node bootstrap can fail on SELinux-enforcing hosts when atomic writes create temp files under
/tmp, causing the final renamed file to retain an incompatible SELinux label.renameiotemp files in the destination directory instead of the default temp dir.pkg/utils/utilio.