Makefile: run generators in parallel #4088
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know necessarily what the benefits are for the built-in Go generation stanzas, but `go generate` runs everything without parallelism, which makes the `make generate` target very slow. We can hack around this without asking anyone to stop using Go generate markers by finding packages we need to generate and running them individually. As long as the output is independent, this is safe. Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
mociarain,
kimorris27,
tsatam,
bitoku,
fahlmant and
sankur-codes
as code owners
kimorris27
approved these changes
Feb 6, 2025
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kimorris27
requested changes
Feb 10, 2025
| .PHONY: generate-parallel | ||
| generate-parallel: install-tools | ||
| grep -rl 'go:generate' | grep -v 'vendor/' | xargs -P 0 -I {} bash -c 'go generate "./$$(dirname {})"' | ||
| $(MAKE) imports |
There was a problem hiding this comment.
This errors out for me saying the make target imports doesn't exist. What was this line supposed to do?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know necessarily what the benefits are for the built-in Go generation stanzas, but
go generateruns everything without parallelism, which makes themake generatetarget very slow. We can hack around this without asking anyone to stop using Go generate markers by finding packages we need to generate and running them individually. As long as the output is independent, this is safe.Before:
After: