Enhance pod.containerstatuses metric to include lastTerminationState of failed pods #4128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yadneshk
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
mociarain,
kimorris27,
tsatam,
bitoku,
fahlmant and
sankur-codes
as code owners
yadneshk
force-pushed
the
yadneshk/ARO-7793-oomkilled-pods
branch
2 times, most recently
from
c15f2c0 to
2f4b4ce
Compare
|
LGTM, |
yadneshk
force-pushed
the
yadneshk/ARO-7793-oomkilled-pods
branch
from
2f4b4ce to
c912e13
Compare
yadneshk
force-pushed
the
yadneshk/ARO-7793-oomkilled-pods
branch
from
c912e13 to
94755ce
Compare
kimorris27
reviewed
Mar 17, 2025
yadneshk
force-pushed
the
yadneshk/ARO-7793-oomkilled-pods
branch
2 times, most recently
from
e849fd3 to
4955cb8
Compare
kimorris27
previously approved these changes
Mar 18, 2025
yadneshk
changed the title
kimorris27
dismissed
their stale review
Withdrawing my approval to wait for canary test results.
yadneshk
requested review from
pepedocs,
edisonLcardenas,
kimorris27 and
wanghaoran1988
kimorris27
previously approved these changes
Mar 25, 2025
bizz001
reviewed
Apr 1, 2025
yadneshk
force-pushed
the
yadneshk/ARO-7793-oomkilled-pods
branch
2 times, most recently
from
7408707 to
dc66c97
Compare
kimorris27
previously approved these changes
May 21, 2025
Capture and include LastTerminationState in pod container status metrics. This includes pods in the Waiting state (not ready), indicating that their last termination state must have contributed to their current condition.
yadneshk
force-pushed
the
yadneshk/ARO-7793-oomkilled-pods
branch
from
dc66c97 to
6b91046
Compare
kimorris27
approved these changes
May 21, 2025
edisonLcardenas
approved these changes
May 29, 2025
There was a problem hiding this comment.
Looks good but I suggest to include a link of the TSG/SOP (e.g. Azure RedHat OpenShift Team Doc ) for this monitor.
mhsreddy
pushed a commit
that referenced
this pull request
Jun 2, 2025
Capture and include LastTerminationState in pod container status metrics. This includes pods in the Waiting state (not ready), indicating that their last termination state must have contributed to their current condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-7793
What this PR does / why we need it:
Add the reason for last termination state of pods stuck in waiting state as a dimension in pod.containerstatuses metric. The value of this field could further be used to segregate pod failures such as
OOMKilled.Test plan for issue:
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?