Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARO-15680] Use default openshift version in miwi e2e pipeline #4140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrWinston
Copy link
Collaborator

@mrWinston mrWinston commented Mar 11, 2025

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-13401

What this PR does / why we need it:

  • Fixes miwi e2e pipeline issue e.g.: https://github.com/Azure/ARO-RP/runs/38530144373
  • In a previous PR, the default install version was changed to 4.16.30
  • The E2E pipeline however was hardcoding 4.15.35 as the version it wants to use
  • the cluster

Test plan for issue:

  • PR E2e pipeline should be green

@mrWinston mrWinston changed the title [draft] Use default openshift version in miwi e2e pipeline [Draft] Use default openshift version in miwi e2e pipeline Mar 11, 2025
@mrWinston
Copy link
Collaborator Author

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mrWinston mrWinston changed the title [Draft] Use default openshift version in miwi e2e pipeline [ARO-15680] Use default openshift version in miwi e2e pipeline Mar 11, 2025
@mrWinston
Copy link
Collaborator Author

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

add platform wi roles for 4.16

json isn't a nice format
@mrWinston mrWinston force-pushed the mrWinston/fix-invalid-version-e2e-miwi branch from a70674f to e759145 Compare March 11, 2025 15:08
@mrWinston
Copy link
Collaborator Author

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kimorris27
Copy link
Contributor

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@kimorris27 kimorris27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll wait for e2e to confirm the change before giving an official approval.

@mrWinston
Copy link
Collaborator Author

The current failure seems to be due to the rollout of the new built-in roles. Apart from waiting, i don't really see a good way to work around this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants