Personal/linuxsmiths/wait for ongoing flush must drain flush callback #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
else we can have a deadlock where write_iov_callback() first releases the membuf lock which make wait_for_ongoing_flush() believe that all flush are done and it can take the flush_lock safely, but write_iov_callback() calls on_flush_complete() later which grabs the flush_lock. This can cause a deadlock. The fix is to let the callback drain. Since wait_for_ongoing_flush() is a rarely used function, we make that check while write_iov_callback() can run w/o any additional check or complexity. Another way of solving this would be to release the membuf lock after on_flush_complete() runs, but then it would have added unncessary restrictions on what we can do insode on_flush_complete().
|
already merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.