fix: test and fix windows VHD release process#8605
Merged
Conversation
timmy-wright
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd and
zachary-bailey
as code owners
timmy-wright
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows VHD build flow to support sourcing embargo Windows base images from a direct shared gallery, while also fixing pipeline file override variable passing and ignoring local test/dev artifacts.
Changes:
- Replaces legacy SIG source coordinates with
direct_shared_gallery_image_idin Windows Packer settings. - Adds optional
sig_source_gallery_nameto Windows settings schema and resolves shared-gallery image versions dynamically. - Passes copy-template parameters through environment variables and expands
.gitignore.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
vhdbuilder/packer/windows/windows-vhd-builder-sig.json |
Uses direct shared gallery image ID as the Windows source image input. |
vhdbuilder/packer/produce-packer-settings.sh |
Emits the new direct shared gallery setting into settings.json. |
vhdbuilder/packer/produce-packer-settings-functions.sh |
Resolves shared gallery source image/version for Windows embargo builds. |
schemas/windows_settings.cue |
Allows Windows SKU entries to specify a source shared gallery name. |
.pipelines/templates/.template-copy-file.yaml |
Exposes template file paths to the bash step via environment variables. |
.gitignore |
Ignores coverage, test result, and devcontainer lock artifacts. |
timmy-wright
added
windows
ignore-for-release
djsly
approved these changes
May 30, 2026
djsly
approved these changes
May 30, 2026
timmy-wright
force-pushed
the
timmy/test-embargo-process
branch
from
93d8148 to
d6b9d65
Compare
djsly
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing windows embargo process & getting it working from alternate galleries.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #