fix(e2e): retry localdns restart in cold-start validator#8649
Open
jingwenw15 wants to merge 1 commit into
Open
fix(e2e): retry localdns restart in cold-start validator#8649jingwenw15 wants to merge 1 commit into
jingwenw15 wants to merge 1 commit into
Conversation
jingwenw15
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a bounded-retry wrapper around systemctl restart localdns in the localdns cold-start validator to reduce test flakiness from transient restart failures during async systemd/network cleanup.
Changes:
- Introduce
restart_localdns_with_retryhelper with logging and bounded retries. - Replace direct
systemctl restart localdnscalls with the retry helper across the cold-start validation flow.
| local retry_delay=5 | ||
| local attempt rc=0 | ||
|
|
||
| for attempt in $(seq 1 "$max_attempts"); do |
Comment on lines
+1996
to
+1997
| rc=$? | ||
| echo "WARNING: localdns restart failed on attempt ${attempt}/${max_attempts} (${reason})" |
| echo "$1" | grep -qE '^[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+$' | ||
| } | ||
|
|
||
| # Helper: restart localdns with bounded retries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #