-
Notifications
You must be signed in to change notification settings - Fork 271
feat: add erofs snapshotter configuration for new kata-preview runtime class #9085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,27 @@ | ||
| version = 2 | ||
| oom_score = -999{{if getHasDataDir .KubeletConfig}} | ||
| root = "{{.KubeletConfig.GetContainerDataDir}}"{{- end}} | ||
| {{- if .GetIsKata }} | ||
| [plugins."io.containerd.snapshotter.v1.erofs"] | ||
| default_size = "10G" | ||
| enable_fsverity = false | ||
| ovl_mount_options = [] | ||
| max_unmerged_layers = 1 | ||
|
|
||
| [plugins."io.containerd.service.v1.diff-service"] | ||
| default = ["erofs", "walking"] | ||
|
|
||
| [plugins."io.containerd.differ.v1.erofs"] | ||
| mkfs_options = ["-T0", "--mkfs-time", "--sort=none"] | ||
| enable_tar_index = false | ||
| {{- end}} | ||
| [plugins."io.containerd.grpc.v1.cri"] | ||
| sandbox_image = "{{ .KubeBinaryConfig.GetPodInfraContainerImageUrl }}" | ||
| enable_cdi = true | ||
| [plugins."io.containerd.grpc.v1.cri".containerd] | ||
| {{- if .GetIsKata }} | ||
| disable_snapshot_annotations = false | ||
| snapshotter = "overlayfs" | ||
| {{- end}} | ||
| {{- if .GetEnableArtifactStreaming }} | ||
| snapshotter = "overlaybd" | ||
|
|
@@ -62,6 +77,7 @@ root = "{{.KubeletConfig.GetContainerDataDir}}"{{- end}} | |
| {{- if .GetIsKata }} | ||
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata] | ||
| runtime_type = "io.containerd.kata.v2" | ||
| snapshotter = "overlayfs" | ||
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.katacli] | ||
| runtime_type = "io.containerd.runc.v1" | ||
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.katacli.options] | ||
|
|
@@ -74,6 +90,12 @@ root = "{{.KubeletConfig.GetContainerDataDir}}"{{- end}} | |
| Root = "" | ||
| CriuPath = "" | ||
| SystemdCgroup = false | ||
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata-preview] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this the final name of the runtimeclass? CC @allyford Maybe let's leave a TODO to define the exact name when we're ready to onboard the rc. |
||
| runtime_type = "io.containerd.kata.v2" | ||
| privileged_without_host_devices = true | ||
| snapshotter = "erofs" | ||
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata-preview.options] | ||
| ConfigPath = "/usr/share/defaults/kata-containers/configuration-clh-templating.toml" | ||
| [proxy_plugins] | ||
| [proxy_plugins.tardev] | ||
| type = "snapshot" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1821,12 +1821,27 @@ const ( | |
| containerdV1ConfigTemplate ContainerdConfigTemplate = `version = 2 | ||
| oom_score = -999{{if HasDataDir }} | ||
| root = "{{GetDataDir}}"{{- end}} | ||
| {{- if IsKata }} | ||
| [plugins."io.containerd.snapshotter.v1.erofs"] | ||
| default_size = "10G" | ||
| enable_fsverity = false | ||
| ovl_mount_options = [] | ||
| max_unmerged_layers = 1 | ||
|
|
||
| [plugins."io.containerd.service.v1.diff-service"] | ||
| default = ["erofs", "walking"] | ||
|
|
||
| [plugins."io.containerd.differ.v1.erofs"] | ||
| mkfs_options = ["-T0", "--mkfs-time", "--sort=none"] | ||
|
Camelron marked this conversation as resolved.
|
||
| enable_tar_index = false | ||
| {{- end}} | ||
| [plugins."io.containerd.grpc.v1.cri"] | ||
| sandbox_image = "{{GetPodInfraContainerSpec}}" | ||
| enable_cdi = true | ||
| [plugins."io.containerd.grpc.v1.cri".containerd] | ||
| {{- if IsKata }} | ||
| disable_snapshot_annotations = false | ||
| snapshotter = "overlayfs" | ||
| {{- end}} | ||
| {{- if IsArtifactStreamingEnabled }} | ||
| snapshotter = "overlaybd" | ||
|
Camelron marked this conversation as resolved.
|
||
|
|
@@ -1883,8 +1898,15 @@ root = "{{GetDataDir}}"{{- end}} | |
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata] | ||
| runtime_type = "io.containerd.kata.v2" | ||
| privileged_without_host_devices = true | ||
| snapshotter = "overlayfs" | ||
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata.options] | ||
| ConfigPath = "/usr/share/defaults/kata-containers/configuration.toml" | ||
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata-preview] | ||
| runtime_type = "io.containerd.kata.v2" | ||
| privileged_without_host_devices = true | ||
| snapshotter = "erofs" | ||
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata-preview.options] | ||
|
Comment on lines
+1904
to
+1908
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm pushing a second commit containing the same template changes mirrored to these files. @cameronmeissner @Bickor can someone double check here and explain the difference?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll let @cameronmeissner explain the difference here, I don't know the answer.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the past I've made changes only to baker.go (ex: https://github.com/Azure/AgentBaker/pull/6816/changes) I think with that we should be good, but I'll let Cameron chime in in case it has changed now and we need changes to both. |
||
| ConfigPath = "/usr/share/defaults/kata-containers/configuration-clh-templating.toml" | ||
| [proxy_plugins] | ||
| [proxy_plugins.tardev] | ||
| type = "snapshot" | ||
|
|
@@ -1901,6 +1923,20 @@ root = "{{GetDataDir}}"{{- end}} | |
| containerdV2ConfigTemplate ContainerdConfigTemplate = `version = 2 | ||
| oom_score = -999{{if HasDataDir }} | ||
| root = "{{GetDataDir}}"{{- end}} | ||
| {{- if IsKata }} | ||
| [plugins."io.containerd.snapshotter.v1.erofs"] | ||
| default_size = "10G" | ||
| enable_fsverity = false | ||
| ovl_mount_options = [] | ||
| max_unmerged_layers = 1 | ||
|
|
||
| [plugins."io.containerd.service.v1.diff-service"] | ||
| default = ["erofs", "walking"] | ||
|
|
||
| [plugins."io.containerd.differ.v1.erofs"] | ||
| mkfs_options = ["-T0", "--mkfs-time", "--sort=none"] | ||
| enable_tar_index = false | ||
| {{- end}} | ||
| [plugins."io.containerd.cri.v1.images"] | ||
| {{- if IsArtifactStreamingEnabled }} | ||
| snapshotter = "overlaybd" | ||
|
|
@@ -1956,8 +1992,15 @@ root = "{{GetDataDir}}"{{- end}} | |
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata] | ||
| runtime_type = "io.containerd.kata.v2" | ||
| privileged_without_host_devices = true | ||
| snapshotter = "overlayfs" | ||
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata.options] | ||
| ConfigPath = "/usr/share/defaults/kata-containers/configuration.toml" | ||
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata-preview] | ||
| runtime_type = "io.containerd.kata.v2" | ||
| privileged_without_host_devices = true | ||
| snapshotter = "erofs" | ||
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata-preview.options] | ||
| ConfigPath = "/usr/share/defaults/kata-containers/configuration-clh-templating.toml" | ||
| [proxy_plugins] | ||
| [proxy_plugins.tardev] | ||
| type = "snapshot" | ||
|
|
@@ -1974,6 +2017,20 @@ root = "{{GetDataDir}}"{{- end}} | |
| containerdV2NoGPUConfigTemplate ContainerdConfigTemplate = `version = 2 | ||
| oom_score = -999{{if HasDataDir }} | ||
| root = "{{GetDataDir}}"{{- end}} | ||
| {{- if IsKata }} | ||
| [plugins."io.containerd.snapshotter.v1.erofs"] | ||
| default_size = "10G" | ||
| enable_fsverity = false | ||
| ovl_mount_options = [] | ||
| max_unmerged_layers = 1 | ||
|
|
||
| [plugins."io.containerd.service.v1.diff-service"] | ||
| default = ["erofs", "walking"] | ||
|
|
||
| [plugins."io.containerd.differ.v1.erofs"] | ||
| mkfs_options = ["-T0", "--mkfs-time", "--sort=none"] | ||
| enable_tar_index = false | ||
| {{- end}} | ||
| [plugins."io.containerd.cri.v1.images"] | ||
| {{- if IsArtifactStreamingEnabled }} | ||
| snapshotter = "overlaybd" | ||
|
|
@@ -2016,8 +2073,15 @@ root = "{{GetDataDir}}"{{- end}} | |
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata] | ||
| runtime_type = "io.containerd.kata.v2" | ||
| privileged_without_host_devices = true | ||
| snapshotter = "overlayfs" | ||
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata.options] | ||
| ConfigPath = "/usr/share/defaults/kata-containers/configuration.toml" | ||
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata-preview] | ||
| runtime_type = "io.containerd.kata.v2" | ||
| privileged_without_host_devices = true | ||
| snapshotter = "erofs" | ||
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata-preview.options] | ||
| ConfigPath = "/usr/share/defaults/kata-containers/configuration-clh-templating.toml" | ||
| [proxy_plugins] | ||
| [proxy_plugins.tardev] | ||
| type = "snapshot" | ||
|
|
@@ -2027,11 +2091,26 @@ root = "{{GetDataDir}}"{{- end}} | |
| containerdV1NoGPUConfigTemplate ContainerdConfigTemplate = `version = 2 | ||
| oom_score = -999{{if HasDataDir }} | ||
| root = "{{GetDataDir}}"{{- end}} | ||
| {{- if IsKata }} | ||
| [plugins."io.containerd.snapshotter.v1.erofs"] | ||
| default_size = "10G" | ||
| enable_fsverity = false | ||
| ovl_mount_options = [] | ||
| max_unmerged_layers = 1 | ||
|
|
||
| [plugins."io.containerd.service.v1.diff-service"] | ||
| default = ["erofs", "walking"] | ||
|
|
||
| [plugins."io.containerd.differ.v1.erofs"] | ||
| mkfs_options = ["-T0", "--mkfs-time", "--sort=none"] | ||
| enable_tar_index = false | ||
| {{- end}} | ||
| [plugins."io.containerd.grpc.v1.cri"] | ||
| sandbox_image = "{{GetPodInfraContainerSpec}}" | ||
| [plugins."io.containerd.grpc.v1.cri".containerd] | ||
| {{- if IsKata }} | ||
| disable_snapshot_annotations = false | ||
| snapshotter = "overlayfs" | ||
| {{- end}} | ||
| {{- if IsArtifactStreamingEnabled }} | ||
| snapshotter = "overlaybd" | ||
|
Camelron marked this conversation as resolved.
|
||
|
|
@@ -2073,8 +2152,15 @@ root = "{{GetDataDir}}"{{- end}} | |
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata] | ||
| runtime_type = "io.containerd.kata.v2" | ||
| privileged_without_host_devices = true | ||
| snapshotter = "overlayfs" | ||
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata.options] | ||
| ConfigPath = "/usr/share/defaults/kata-containers/configuration.toml" | ||
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata-preview] | ||
| runtime_type = "io.containerd.kata.v2" | ||
| privileged_without_host_devices = true | ||
| snapshotter = "erofs" | ||
| [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.kata-preview.options] | ||
| ConfigPath = "/usr/share/defaults/kata-containers/configuration-clh-templating.toml" | ||
| [proxy_plugins] | ||
| [proxy_plugins.tardev] | ||
| type = "snapshot" | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.