Skip to content

Fix GitHubAuditData dropping rows when source timestamp is missing - #15015

Open
d4rk pr10r (d4rk-pri0r) wants to merge 2 commits into
Azure:masterfrom
d4rk-pri0r:fix/14659-githubauditdata-timegenerated
Open

Fix GitHubAuditData dropping rows when source timestamp is missing#15015
d4rk pr10r (d4rk-pri0r) wants to merge 2 commits into
Azure:masterfrom
d4rk-pri0r:fix/14659-githubauditdata-timegenerated

Conversation

@d4rk-pri0r

Copy link
Copy Markdown
Contributor

Summary

Closes #14659

Test Plan

  • Confirm the three TimeGenerated= lines in the parser YAML use coalesce + column_ifexists
  • Confirm Package/mainTemplate.json embeds coalesce(unixtime (not the old unguarded calls only)
  • V3 package version is 3.5.2 throughout

Unguarded unixtime_milliseconds_todatetime on created_at_d/CreatedAt
nulled TimeGenerated and dropped rows. Use coalesce with
column_ifexists fallback on all three views.

V3-repackage GitHub solution 3.5.1 -> 3.5.2.

Closes Azure#14659
@v-atulyadav
v-atulyadav requested a lite review from Copilot August 31, 2026 06:16
@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Aug 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR prevents GitHub audit rows from disappearing when the source timestamp field is missing by falling back to ingestion TimeGenerated, and bumps the parser/solution versions accordingly.

Changes:

  • Update GitHubAuditData parser to use coalesce(unixtime_milliseconds_todatetime(column_ifexists(...)), TimeGenerated) for TimeGenerated.
  • Bump parser version 1.1.01.1.1 and solution/package version 3.5.13.5.2.
  • Document the change in release notes.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.

File Description
Solutions/GitHub/data/Solution_GitHub.json Bumps GitHub solution version to 3.5.2.
Solutions/GitHub/ReleaseNotes.md Adds a 3.5.2 entry describing the parser fix.
Solutions/GitHub/Parsers/GitHubAuditData.yaml Guards source timestamp conversion to preserve ingestion TimeGenerated.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Solutions/GitHub/Parsers/GitHubAuditData.yaml Outdated
Comment thread Solutions/GitHub/Parsers/GitHubAuditData.yaml Outdated
Comment thread Solutions/GitHub/Parsers/GitHubAuditData.yaml Outdated
@v-maheshbh

Copy link
Copy Markdown
Contributor

Hi d4rk pr10r (@d4rk-pri0r)

Kindly verify the Copilot comments, make the necessary changes, and mark the conversations as resolved.

Thanks!

Copilot: unixtime_milliseconds_todatetime expects integer milliseconds.
column_ifexists default real(null) could widen the type. Use long(null).

Parser 1.1.2. V3 package 3.5.3.
@d4rk-pri0r

Copy link
Copy Markdown
Contributor Author

Hi v-maheshbh (@v-maheshbh) — Copilot comments addressed.

All three column_ifexists(..., real(null)) defaults are now long(null) so unixtime_milliseconds_todatetime stays on integer milliseconds. Parser 1.1.2, V3 package 3.5.3. Conversations resolved.

@v-maheshbh

Copy link
Copy Markdown
Contributor

Hi d4rk pr10r (@d4rk-pri0r)

image

Kindly repackage the solution with 3.5.2, as the previous package version was 3.5.1. Please update the release notes accordingly.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Solution Solution specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHubAuditData parser dropping logs

4 participants