Closed
Conversation
blueww
reviewed
Jul 22, 2025
| - cron: '0 19 * * 0' | ||
|
|
||
| jobs: | ||
| BlobTest_Ubuntu_Node16: |
Member
There was a problem hiding this comment.
Since there are cross coverage from different aspects on each test set, please don't remove any test set, but just update node version of some test sets. To avoid lost test coverage.
Author
There was a problem hiding this comment.
I don't think it's possible to test with node 16 if we explicitly say in package.json we need node>=20
I removed node 16 and 18 and added 24
Member
There was a problem hiding this comment.
you can just update the test sets with Node 16 and Node 18 to use node 22 or node 24, without change other things in the test sets, so we won't lost test coverage in other aspects.
Member
|
The test set based on Node 24 are all failed, this will block node 24 upgrade. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contribution! Please go through following checklist before sending PR.
PR Branch Destination
mainbranch.legacy-devbranch.Always Add Test Cases
Make sure test cases are added to cover the code change.
Add Change Log
Add change log for the code change in
Upcoming Releasesection inChangeLog.md.Development Guideline
Please go to CONTRIBUTION.md for steps about setting up development environment and recommended Visual Studio Code extensions.