Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor directories to make them less flat #24

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Conversation

toma3233
Copy link
Contributor

@toma3233 toma3233 commented Jan 2, 2025

No description provided.

@toma3233 toma3233 marked this pull request as draft January 2, 2025 22:36
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about break up the common package for gRPC and HTTP, respectively and put each common under gRPC and HTTP?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not too much work, move this under grpc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this would be ideal, it just would be a breaking change for mygreeter, guardrails, subnet handler, and tls bootstrap. However, since it's not too many services in this case, we can make the updates for them.

@toma3233 toma3233 marked this pull request as ready for review January 3, 2025 19:00
@toma3233 toma3233 merged commit 0567e39 into main Jan 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants