Refactor directories to make them less flat #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
common/logging/logging_test.go
Outdated
There was a problem hiding this comment.
How about break up the common package for gRPC and HTTP, respectively and put each common under gRPC and HTTP?
interceptor/interceptor.go
Outdated
There was a problem hiding this comment.
If not too much work, move this under grpc.
There was a problem hiding this comment.
I agree that this would be ideal, it just would be a breaking change for mygreeter, guardrails, subnet handler, and tls bootstrap. However, since it's not too many services in this case, we can make the updates for them.
fangluguomsft
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.