Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor templating into a reusable module #218

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Mar 7, 2025

Overview/Summary

This PR refactors the templating code into shared module. This is to enable re-use for the new pattern module tests and avoid duplicated code.

This PR fixes/adds/changes/removes

None

Breaking Changes

None, should not affect the state file at this stage

Testing Evidence

I ran a full deployment locally to confirm there is no state change and the resource group dependency graph still works.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredfholgate jaredfholgate merged commit 9146b52 into main Mar 7, 2025
12 checks passed
@jaredfholgate jaredfholgate deleted the feat-refactor-templating-for-reuse-in-tests branch March 7, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Safe to test 🧪 Enables running of End to End Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants