Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support for management-only scenario #226

Merged
merged 4 commits into from
Mar 20, 2025
Merged

fix: Support for management-only scenario #226

merged 4 commits into from
Mar 20, 2025

Conversation

ASHR4
Copy link
Contributor

@ASHR4 ASHR4 commented Mar 20, 2025 •
edited
Loading

Overview/Summary

The validation for starter_locations within the platform landing zone fails when connectivity_type is set to none. These validation changes were introduced in PR #225.

The issue arises because the validation logic still assesses var.virtual_wan_virtual_hubs and var.hub_and_spoke_vnet_virtual_networks, even though these variables are not supplied when connectivity_type is none.

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@ASHR4 ASHR4 marked this pull request as draft March 20, 2025 17:13
@ASHR4 ASHR4 changed the title fix: fix: Support for management-only scenario Mar 20, 2025
@jaredfholgate
Copy link
Member

jaredfholgate commented Mar 20, 2025 •
edited
Loading

Oops, good spot. I would have seen this if I had run the tests...

@jaredfholgate jaredfholgate added the PR: Safe to test 🧪 Enables running of End to End Tests label Mar 20, 2025
@ASHR4 ASHR4 marked this pull request as ready for review March 20, 2025 17:22
jaredfholgate
jaredfholgate approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ASHR4 ASHR4 merged commit 8817b0e into main Mar 20, 2025
14 checks passed
@ASHR4 ASHR4 deleted the fix/no-connectivity-validations branch March 20, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredfholgate jaredfholgate jaredfholgate approved these changes

Assignees
No one assigned
Labels
PR: Safe to test 🧪 Enables running of End to End Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ASHR4 @jaredfholgate