Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge Storage Accelerator (ESA) - Jumpstart Scenario #277

Merged
merged 50 commits into from
Apr 5, 2024
Merged

Edge Storage Accelerator (ESA) - Jumpstart Scenario #277

merged 50 commits into from
Apr 5, 2024

Conversation

ldabas-msft
Copy link
Contributor

No description provided.

ajoint and others added 15 commits March 21, 2024 14:46
@fcabrera23 fcabrera23 changed the base branch from main to canary April 3, 2024 15:21
@fcabrera23 fcabrera23 changed the title Finalised Documentation Edge Storage Accelerator (ESA) - Jumpstart Scenario Apr 3, 2024
sebassem
sebassem requested changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@sebassem sebassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor changes

dkirby-ms
dkirby-ms requested changes Apr 5, 2024
View reviewed changes
ldabas-msft added 12 commits April 5, 2024 20:53
@ldabas-msft
Delete docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essential…
8aeda5c 
…s_single_esa/02.png
@ldabas-msft
Add files via upload
71c4d4e
@ldabas-msft
Delete docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essential…
c32b68e 
…s_single_esa/03.png
@ldabas-msft
Add files via upload
8d0c75b
@ldabas-msft
Delete docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essential…
887e090 
…s_single_esa/20.png
@ldabas-msft
Delete docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essential…
98ec0e6 
…s_single_esa/35.png.png
@ldabas-msft
Delete docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essential…
3ab8841 
…s_single_esa/36.png.png
@ldabas-msft
Delete docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essential…
bdfb8e4 
…s_single_esa/37.png.png
@ldabas-msft
Delete docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essential…
54e749d 
…s_single_esa/38.png.png
@ldabas-msft
Add files via upload
7ca818e
@ldabas-msft
Update _index.md
d914a64
@ldabas-msft
Update _index.md
c16f0da
@dkirby-ms dkirby-ms self-requested a review April 5, 2024 21:00
dkirby-ms
dkirby-ms requested changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@dkirby-ms dkirby-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Mostly minor formatting stuff.

  • Please remove all unused images including the Akri ones I flagged
  • Notice I suggested change to title of the scenario
  • Also changed the scenario weight to have it align in the right place in JS website.

docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essentials_single_esa/23.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This screenshot shows the old logo. Maybe crop it out?

docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essentials_single_esa/24.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old logo

docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essentials_single_esa/27.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like an Akri screenshot. Remove if not needed

docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essentials_single_esa/21.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old logo

docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essentials_single_esa/26.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Akri related screenshot

docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essentials_single_esa/_index.md Outdated
description: >
---

## Discover Edge Storage Accelerator on AKS Edge Essentials single node deployment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Discover Edge Storage Accelerator on AKS Edge Essentials single node deployment
## Edge Storage Accelerator on AKS Edge Essentials single node deployment

ldabas-msft and others added 9 commits April 5, 2024 22:24
@ldabas-msft
Delete docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essential…
ede577d 
…s_single_esa/25.png
@ldabas-msft
Delete docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essential…
ef0932d 
…s_single_esa/26.png
@ldabas-msft
Delete docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essential…
1385ebb 
…s_single_esa/27.png
@ldabas-msft
Delete docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essential…
3b19b55 
…s_single_esa/29.png
@ldabas-msft
Update _index.md Title
6f5b1ea
@ldabas-msft @dkirby-ms
Update docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essential…
8c85175 
…s_single_esa/_index.md

Co-authored-by: Dale Kirby <[email protected]>
@ldabas-msft @dkirby-ms
Update docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essential…
1a155e2 
…s_single_esa/_index.md

Co-authored-by: Dale Kirby <[email protected]>
@ldabas-msft @dkirby-ms
Update docs/azure_arc_jumpstart/azure_edge_iot_ops/aks_edge_essential…
edf5bd1 
…s_single_esa/_index.md

Co-authored-by: Dale Kirby <[email protected]>
@ldabas-msft
Update _index.md
c8b3b4c
@dkirby-ms dkirby-ms merged commit 43690b1 into Azure:canary Apr 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likamrat likamrat likamrat left review comments

@sebassem sebassem sebassem requested changes

@dkirby-ms dkirby-ms dkirby-ms approved these changes

@ajoint ajoint Awaiting requested review from ajoint

@janegilring janegilring Awaiting requested review from janegilring

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ldabas-msft @dkirby-ms @sebassem @likamrat @ajoint @hariarun18