[WIP] Fix issue with defining multiple explicit clients#3665
Closed
[WIP] Fix issue with defining multiple explicit clients#3665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix multiple explicit clients with multiple services
Problem
The TypeSpec TypeScript emitter's
getRLCClientsfunction was experiencing errors when handling multiple services with explicit@clientdecorators. The error "Can not define multiple explicit clients with multiple services" was being thrown by an older version of TypeSpec Client Generator Core (TCGC).Resolution
Issue resolved upstream - No code changes needed in autorest.typescript.
The validation error was fixed in TCGC version 0.63.0, which added support for:
@clientdecoratorsCurrent Implementation Status
getRLCClientsfunction behaviorImplementation Details
The
getRLCClientsfunction correctly:Test Results
✅ All 311 RLC unit tests passing
✅ Test "should get the @client client if each services have only one @client decorators" passing
✅ Test "should handle both 1:1 and 1:N mappings between @service and @client" passing
Conclusion
The issue was resolved by updating to TCGC 0.63.0. No changes to autorest.typescript code are required.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.