Q1 2025 - Updates #758
Open
Q1 2025 - Updates #758
+14,336
−15,183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed Key expiration * updated Groups UI * entraid support * removed extra if * testing with my branch * remove managementvm on entraid * update portal * updated ui * changed EnterpriseApp to ServicePrincipal * updated portal * fixed avdarm * update RBAC * updated url for script * updated ui * fixed createPrivateDNS parameter * fixed identityDomainName in SessionHost Script * added conditions for storage managed identity * added logging to set session host * changed to -command * configure baseuri back to azure * updated doc for identity info * settings * new session host brownfield fix up * merged files * updated json files * fixed reference to sub * fixed hostpool call * updated reference * fixed portalui for new session hosts * fixed validation on deployment prefix * fixed regex * tag regex * fixed modulo function and portal * fixed portal screen * update set-sessionhostconfig.ps1 * update allowed values for tags * updated batch size * unified changes across baseline and new session hosts * fixed keyvault ref * added index to UI * updated publisher reference for all lowercase * added count to UI * fixed vmsize count reference * fixed custom image in portal ui * updated docs and reverted script path to azure repo * fixed the servicePrincpalApiCalls * fixed condition on serviceprincipal blade controls and outputs. * updated to match azure repo in leue of sync * Update deploy.bicep --------- Co-authored-by: Dany Contreras <[email protected]>
…vdaccelerator into EntraID-Storage-Features
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "location": "[parameters('location')]", | ||
| "properties": { | ||
| "source": { | ||
| "script": "param (\r\n [string]$StorageAccountName,\r\n [string]$StorageAccountSuffix,\r\n [string]$StorageAccountKey\r\n)\r\n\r\nStart-Process -FilePath 'cmdkey.exe' -ArgumentList \"/add:$($StorageAccountName).file.$($StorageAccountSuffix) /user:localhost\\$($StorageAccountName) /pass:$($StorageAccountKey)\" -NoNewWindow -Wait\r\n " |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
| If ($FsLogixStorageAccountKey -ne '') { | ||
| $SAName = $FSLogixStorageFQDN.Split('.')[0] | ||
| Write-Log -Message "Adding Local Storage Account Key for '$FSLogixStorageFQDN' to Credential Manager" -Category 'Info' | ||
| $CMDKey = Start-Process -FilePath 'cmdkey.exe' -ArgumentList "/add:$FSLogixStorageFQDN /user:localhost\$SAName /pass:$FSLogixStorageAccountKey" -Wait -PassThru |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
There was a problem hiding this comment.
this is not debug code
…es' of https://github.com/Azure/avdaccelerator into EntraID-Storage-Features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
.bicepfile/s I am adding/editing are using the latest API version possiblemainbranch