[build] add code coverage to provider_integration workflow by zimmy87 · Pull Request #352 · Azure/azihsm-sdk

zimmy87 · 2026-04-30T01:05:58Z

No description provided.

…k in provider_integration workflow

Copilot

Pull request overview

This PR updates the repo’s xtask and CI workflow so the provider_integration GitHub Actions job runs integration tests under cargo llvm-cov and emits a coverage summary via xtask precheck --coverage-report.

Changes:

Extend xtask coverage to accept nextest-like arguments (features/package/profile/filterset/exclude) and forward them to cargo llvm-cov nextest.
Update xtask precheck to pass coverage configuration (and to run multiple coverage invocations in the default “SDK” path).
Switch provider_integration workflow steps from --nextest to --coverage, and add a coverage summary step.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
`xtask/src/precheck.rs`	Routes `precheck --coverage` into parameterized `Coverage` runs (default SDK + resiliency runs, or user-provided package/features).
`xtask/src/coverage.rs`	Adds CLI flags to `Coverage` and builds argument lists for `cargo llvm-cov nextest`.
`.github/workflows/rust.yml`	Runs provider integration test packages with coverage and adds a coverage summary report step.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…g sdk-cov.json Agent-Logs-Url: https://github.com/Azure/azihsm-sdk/sessions/36ef3ca2-4175-4870-bd8a-2cfb4384dfc3 Co-authored-by: zimmy87 <5205889+zimmy87@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

…h default precheck runs Agent-Logs-Url: https://github.com/Azure/azihsm-sdk/sessions/c036d7d2-3887-40af-8d85-48d245439a70 Co-authored-by: zimmy87 <5205889+zimmy87@users.noreply.github.com>

…flow

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

…LAGS

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

+        // append /target/debug/libazihsm_api_native.so to LLVM_COV_FLAGS
+        let additional_libs = ["./target/debug/libazihsm_api_native.so"];
+        for lib in &additional_libs {
+            if std::path::Path::new(lib).exists() {
+                let new_flags = match std::env::var("LLVM_COV_FLAGS") {
+                    Ok(existing) if !existing.trim().is_empty() => {
+                        format!("{existing} -object {lib}")
+                    }
+                    _ => format!("-object {lib}"),
+                };
+                sh.set_var("LLVM_COV_FLAGS", new_flags);
+            } else {
+                log::warn!("Could not find library at expected path: {}. Coverage reports may be incomplete.", lib);
+            }


…n remaining test steps in provider_integration

…rt xtask behavior

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

+        let filterset_val = self.filterset.clone().unwrap_or_default();
+        if self.filterset.is_some() {
+            command_args.push("--filterset");
+            command_args.push(&filterset_val);
+        }


+        // set LLVM_COV_FLAGS to include azihsm_api_native object file in coverage reports
+        if let Some(native_obj_path) = native_obj_path {
+            if native_obj_path.is_file() {
+                let path_str = native_obj_path.to_string_lossy();
+                let new_flags = match std::env::var("LLVM_COV_FLAGS") {
+                    Ok(existing) if !existing.trim().is_empty() => {
+                        format!("{existing} -object {path_str}")
+                    }
+                    _ => format!("-object {path_str}"),
+                };


Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

+                // Run resiliency fault-injection tests with coverage
+                Coverage {
+                    features: Some("mock,res-test".to_string()),
+                    package: Some("azihsm_api_tests".to_string()),
+                    no_default_features: false,
+                    filterset: Some("test(resiliency::fault_injection::)".to_string()),
+                    profile: self.profile.clone().or(Some("ci-mock-res".to_string())),
+                    exclude: self.exclude.clone(),
+                }
+                .run(ctx.clone())?;


+        // Run tests with coverage
+        log::info!("Building all tests and running them with coverage");
        cmd!(
            sh,
-            "cargo llvm-cov report --json --summary-only --output-path ./target/reports/sdk-cov.json --ignore-filename-regex xtask*"
-        ).run()?;
-
-        // Generate HTML report
-        log::info!("Generating HTML report");
-        cmd!(sh, " cargo llvm-cov report --html --output-dir ./target/reports/sdk-cov/ --ignore-filename-regex xtask*").run()?;
+            "cargo llvm-cov nextest --no-report --no-fail-fast {command_args...}"
+        )
+        .run()?;

        log::info!("Code coverage completed successfully");
        Ok(())


add parameters to coverage xtask and call it in place of nextest xtas…

ae92d55

…k in provider_integration workflow

Copilot AI review requested due to automatic review settings April 30, 2026 01:05

zimmy87 linked an issue Apr 30, 2026 that may be closed by this pull request

[task] add code coverage to provider_integration #348

Open

Copilot started reviewing on behalf of zimmy87 April 30, 2026 01:06 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread xtask/src/precheck.rs Outdated

Comment thread .github/workflows/rust.yml

Comment thread xtask/src/coverage.rs Outdated

Comment thread xtask/src/precheck.rs Outdated

zimmy87 added 2 commits April 30, 2026 11:35

fmt fixes

4b7a914

Merge branch 'main' into user/v-davidz/provider_integration_cov

3ddc7ca

Copilot started work on behalf of zimmy87 April 30, 2026 20:37 View session

Update xtask/src/coverage.rs

aad1538

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 30, 2026 20:38

Copilot started reviewing on behalf of zimmy87 April 30, 2026 20:38 View session

fix: run coverage-report after each coverage step to avoid overwritin…

798d93c

…g sdk-cov.json Agent-Logs-Url: https://github.com/Azure/azihsm-sdk/sessions/36ef3ca2-4175-4870-bd8a-2cfb4384dfc3 Co-authored-by: zimmy87 <5205889+zimmy87@users.noreply.github.com>

Copilot finished work on behalf of zimmy87 April 30, 2026 20:41

Copilot started work on behalf of zimmy87 April 30, 2026 20:41 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread xtask/src/precheck.rs Outdated

fix: use no_report flag to generate combined coverage report from bot…

2492ab1

…h default precheck runs Agent-Logs-Url: https://github.com/Azure/azihsm-sdk/sessions/c036d7d2-3887-40af-8d85-48d245439a70 Co-authored-by: zimmy87 <5205889+zimmy87@users.noreply.github.com>

Copilot finished work on behalf of zimmy87 April 30, 2026 20:46

remove superfluous coverage-report steps in provider_integration work…

61771e4

…flow

Copilot AI review requested due to automatic review settings May 1, 2026 18:32

Copilot started reviewing on behalf of zimmy87 May 1, 2026 18:33 View session

Copilot AI reviewed May 1, 2026

View reviewed changes

zimmy87 added 2 commits May 1, 2026 11:59

fix attempt #2 for missing coverage data

d38828b

fix attempt #3 for missing coverage data

991f069

Copilot AI review requested due to automatic review settings May 1, 2026 19:26

Copilot started reviewing on behalf of zimmy87 May 1, 2026 19:27 View session

Copilot AI reviewed May 1, 2026

View reviewed changes

Comment thread xtask/src/precheck.rs Outdated

Comment thread .github/workflows/rust.yml Outdated

Comment thread xtask/src/coverage.rs Outdated

Comment thread xtask/src/coverage_report.rs

zimmy87 added 3 commits May 5, 2026 11:40

set env vars to instrument ossl provider & add provider to LLVM_COV_F…

3c7014e

…LAGS

Merge branch 'main' into user/v-davidz/provider_integration_cov

311d585

instrument native lib in provider_integration workflow properly

5915132

Copilot AI review requested due to automatic review settings May 18, 2026 18:56

Copilot started reviewing on behalf of zimmy87 May 18, 2026 18:59 View session

Merge branch 'main' into user/v-davidz/provider_integration_cov

53ff9b3

Copilot AI reviewed May 18, 2026

View reviewed changes

zimmy87 added 2 commits May 18, 2026 14:59

move all reporting logic to coverage_report xtask & enable coverage o…

50bafc0

…n remaining test steps in provider_integration

move upload of coverage reports to accomodate change in coverage-repo…

40137dc

…rt xtask behavior

Copilot AI review requested due to automatic review settings May 18, 2026 23:41

Copilot started reviewing on behalf of zimmy87 May 18, 2026 23:43 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

zimmy87 added 2 commits May 18, 2026 17:25

copilot feedback

dbf10ac

remove debug steps in provider_integration workflow

571f388

Copilot AI review requested due to automatic review settings May 19, 2026 00:29

Copilot started reviewing on behalf of zimmy87 May 19, 2026 00:32 View session

Copilot AI reviewed May 19, 2026

View reviewed changes

Conversation

zimmy87 commented Apr 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants