Skip to content

[fix] update Windows runner to windows-2025-vs2026#367

Open
Copilot wants to merge 9 commits into
mainfrom
copilot/update-windows-runner-to-windows-2025-vs2026
Open

[fix] update Windows runner to windows-2025-vs2026#367
Copilot wants to merge 9 commits into
mainfrom
copilot/update-windows-runner-to-windows-2025-vs2026

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 6, 2026 •
edited by zimmy87
Loading

GitHub is redirecting windows-2025 runner requests to windows-2025-vs2026 by May 12, 2026. Pinning explicitly to windows-2025-vs2026 now surfaces any breaking changes from the VS2026 toolchain ahead of the forced migration.

Changes

Copilot AI requested review from Copilot and removed request for Copilot May 6, 2026 00:48
Copilot AI linked an issue May 6, 2026 that may be closed by this pull request
[task] update windows runner to windows-2025-vs2026 #366
Open
Copilot AI requested review from Copilot and removed request for Copilot May 6, 2026 00:51
Copilot AI changed the title [WIP] Update Windows runner to windows-2025-vs2026 chore: update Windows runner to windows-2025-vs2026 May 6, 2026
Copilot AI requested a review from zimmy87 May 6, 2026 00:52
Copilot finished work on behalf of zimmy87 May 6, 2026 00:52
@zimmy87 zimmy87 changed the title chore: update Windows runner to windows-2025-vs2026 [fix] update Windows runner to windows-2025-vs2026 May 6, 2026
zimmy87
zimmy87 requested changes May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@zimmy87 zimmy87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the windows workflow is failing due to a Cmake error in api\tests\cpp\CMakeLists.txt:

CMake Error at CMakeLists.txt:5 (project):
Generator

  Visual Studio 17 2022

could not find any instance of Visual Studio.

please upgrade the generator to one appropriate for Visual Studio 18 2026 by updating api\tests\build.rs and fix any additional workflow failures caused by the upgrade

Copilot AI review requested due to automatic review settings May 8, 2026 19:58
Copilot AI reviewed May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins Windows GitHub Actions jobs to the upcoming VS2026-based runner image to proactively surface any toolchain-related breaking changes before the platform redirect takes effect.

Changes:

  • Update the build_windows job runner from windows-latest to windows-2025-vs2026.
  • Update the cache-refresh Windows job runner from windows-latest to windows-2025-vs2026.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/rust.yml Pins the Windows build/test CI job to windows-2025-vs2026.
.github/workflows/create_new_cache.yml Pins the Windows cache creation job to windows-2025-vs2026.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 8, 2026

the windows workflow is failing due to a Cmake error in api\tests\cpp\CMakeLists.txt:

CMake Error at CMakeLists.txt:5 (project):...

Fixed in dc9ab61 — updated the generator string in api/tests/build.rs from "Visual Studio 17 2022" to "Visual Studio 18 2026" and updated the accompanying comment to match.

Copilot finished work on behalf of zimmy87 May 8, 2026 20:01
Copilot AI requested a review from zimmy87 May 8, 2026 20:01
Copilot AI review requested due to automatic review settings May 11, 2026 21:19
Copilot AI reviewed May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread api/tests/build.rs Outdated
Comment thread api/tests/build.rs
Copilot AI review requested due to automatic review settings May 12, 2026 00:11
Copilot AI reviewed May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comment thread api/tests/cpp/CMakeLists.txt
Comment thread api/tests/build.rs
@zimmy87 zimmy87 marked this pull request as ready for review May 12, 2026 00:20
Copilot AI review requested due to automatic review settings May 12, 2026 18:42
Copilot AI reviewed May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@zimmy87 zimmy87 zimmy87 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@zimmy87 zimmy87

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[task] update windows runner to windows-2025-vs2026

3 participants

@zimmy87