Skip to content

Fixing Issue with Power BI and Excel #531#535

Merged
cmendible merged 2 commits intomainfrom
issue-531
Aug 8, 2025
Merged

Fixing Issue with Power BI and Excel #531#535
cmendible merged 2 commits intomainfrom
issue-531

Conversation

@cmendible
Copy link
Copy Markdown
Member

This pull request removes the creation of pivot tables for recommendations in the Excel report generation process. The related functions and logic for tracking the last row of recommendations and generating the pivot tables have been deleted, simplifying the codebase.

Removal of Recommendations Pivot Table Feature

  • Deleted the renderRecommendationsPivotTables function and all logic related to creating pivot tables for recommendations in the Excel report, including the use of lastRow to determine data range (internal/renderers/excel/excel.go, internal/renderers/excel/recommendations.go) [1] [2] [3].

Code Simplification

  • Updated the renderRecommendations function to no longer return the last row index, as it is no longer needed for pivot table creation (internal/renderers/excel/recommendations.go) [1] [2].
  • Removed unused imports (fmt, strconv) that were only required for pivot table creation (internal/renderers/excel/recommendations.go).# Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #531

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing

@cmendible cmendible merged commit 27b038e into main Aug 8, 2025
11 checks passed
@cmendible cmendible deleted the issue-531 branch August 8, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error to load excel file to PowerBI template.

1 participant